Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers

2020-04-21 Thread Ranjit Menon
On 4/14/2020 12:44 PM, Dmitry Kozlyuk wrote: diff --git a/lib/librte_eal/windows/eal_memory.c b/lib/librte_eal/windows/eal_memory.c new file mode 100644 index 0..5697187ce --- /dev/null +++ b/lib/librte_eal/windows/eal_memory.c @@ -0,0 +1,437 @@ + + if ((flags & EAL_RESERVE_

Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers

2020-04-21 Thread Ranjit Menon
On 4/14/2020 12:44 PM, Dmitry Kozlyuk wrote: System meory management is implemented differently for POSIX and Windows. Introduce wrapper functions for operations used across DPDK: * rte_mem_map() Create memory mapping for a regular file or a page file (swap). This supports mapping to a res

Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers

2020-04-21 Thread Dmitry Kozlyuk
> I'd remove the GetVersionEx check entirely and add the comments regarding OS > dependency to the RTE_LOG > Of the LoadLibraryA failure below, GetVersionEx returns the Windows 8 OS > version on newer servers Agreed, will do in v4. > Also, it looks like not all Win2016 servers versions support

Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers

2020-04-19 Thread Tal Shnaiderman
> System meory management is implemented differently for POSIX and > Windows. Introduce wrapper functions for operations used across DPDK: > > * rte_mem_map() > Create memory mapping for a regular file or a page file (swap). > This supports mapping to a reserved memory region even on Windows.

Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers

2020-04-17 Thread Burakov, Anatoly
On 14-Apr-20 8:44 PM, Dmitry Kozlyuk wrote: System meory management is implemented differently for POSIX and Windows. Introduce wrapper functions for operations used across DPDK: * rte_mem_map() Create memory mapping for a regular file or a page file (swap). This supports mapping to a rese

Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers

2020-04-15 Thread Dmitry Kozlyuk
Answering the questions. All snipped comments will be fixed in v4. > [...] > > +/** > > + * Memory reservation flags. > > + */ > > +enum eal_mem_reserve_flags { > > + /**< Reserve hugepages (support may be limited or missing). */ > > + EAL_RESERVE_HUGEPAGES = 1 << 0, > > + /**< Fail if reque

Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers

2020-04-15 Thread Thomas Monjalon
14/04/2020 21:44, Dmitry Kozlyuk: > System meory management is implemented differently for POSIX and meory -> memory > Windows. Introduce wrapper functions for operations used across DPDK: > > * rte_mem_map() > Create memory mapping for a regular file or a page file (swap). > This supports m

[dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers

2020-04-14 Thread Dmitry Kozlyuk
System meory management is implemented differently for POSIX and Windows. Introduce wrapper functions for operations used across DPDK: * rte_mem_map() Create memory mapping for a regular file or a page file (swap). This supports mapping to a reserved memory region even on Windows. * rte_mem_u