Re: [dpdk-dev] [PATCH v3 01/22] ethdev: fix MTU size exceeds max rx packet length

2021-01-25 Thread Ferruh Yigit
On 1/19/2021 8:46 AM, oulijun wrote: 在 2021/1/18 18:42, Ferruh Yigit 写道: On 1/15/2021 10:44 AM, oulijun wrote: Hi Steve This is a very good job! But I have some question and suggestions. Please check it. 在 2021/1/14 17:45, Steve Yang 写道: Ethdev is using default Ethernet overhead to decide i

Re: [dpdk-dev] [PATCH v3 01/22] ethdev: fix MTU size exceeds max rx packet length

2021-01-23 Thread oulijun
在 2021/1/19 16:46, oulijun 写道: 在 2021/1/18 18:42, Ferruh Yigit 写道: On 1/15/2021 10:44 AM, oulijun wrote: Hi Steve This is a very good job! But I have some question and suggestions. Please check it. 在 2021/1/14 17:45, Steve Yang 写道: Ethdev is using default Ethernet overhead to decide if p

Re: [dpdk-dev] [PATCH v3 01/22] ethdev: fix MTU size exceeds max rx packet length

2021-01-19 Thread oulijun
在 2021/1/18 18:42, Ferruh Yigit 写道: On 1/15/2021 10:44 AM, oulijun wrote: Hi Steve This is a very good job! But I have some question and suggestions. Please check it. 在 2021/1/14 17:45, Steve Yang 写道: Ethdev is using default Ethernet overhead to decide if provided 'max_rx_pkt_len' value is

Re: [dpdk-dev] [PATCH v3 01/22] ethdev: fix MTU size exceeds max rx packet length

2021-01-18 Thread Ferruh Yigit
On 1/15/2021 10:44 AM, oulijun wrote: Hi Steve This is a very good job! But I have some question and suggestions. Please check it. 在 2021/1/14 17:45, Steve Yang 写道: Ethdev is using default Ethernet overhead to decide if provided 'max_rx_pkt_len' value is bigger than max (non jumbo) MTU value, a

Re: [dpdk-dev] [PATCH v3 01/22] ethdev: fix MTU size exceeds max rx packet length

2021-01-15 Thread oulijun
Hi Steve This is a very good job! But I have some question and suggestions. Please check it. 在 2021/1/14 17:45, Steve Yang 写道: Ethdev is using default Ethernet overhead to decide if provided 'max_rx_pkt_len' value is bigger than max (non jumbo) MTU value, and limits it to MAX if it is. Since th

Re: [dpdk-dev] [PATCH v3 01/22] ethdev: fix MTU size exceeds max rx packet length

2021-01-14 Thread Ferruh Yigit
On 1/14/2021 5:29 PM, Andrew Boyer wrote: On Jan 14, 2021, at 12:13 PM, Ferruh Yigit > wrote: On 1/14/2021 4:36 PM, Ferruh Yigit wrote: On 1/14/2021 9:45 AM, Steve Yang wrote: Ethdev is using default Ethernet overhead to decide if provided 'max_rx_pkt_len' val

Re: [dpdk-dev] [PATCH v3 01/22] ethdev: fix MTU size exceeds max rx packet length

2021-01-14 Thread Andrew Boyer
> On Jan 14, 2021, at 12:13 PM, Ferruh Yigit wrote: > > On 1/14/2021 4:36 PM, Ferruh Yigit wrote: >> On 1/14/2021 9:45 AM, Steve Yang wrote: >>> Ethdev is using default Ethernet overhead to decide if provided >>> 'max_rx_pkt_len' value is bigger than max (non jumbo) MTU value, >>> and limits i

Re: [dpdk-dev] [PATCH v3 01/22] ethdev: fix MTU size exceeds max rx packet length

2021-01-14 Thread Ferruh Yigit
On 1/14/2021 4:36 PM, Ferruh Yigit wrote: On 1/14/2021 9:45 AM, Steve Yang wrote: Ethdev is using default Ethernet overhead to decide if provided 'max_rx_pkt_len' value is bigger than max (non jumbo) MTU value, and limits it to MAX if it is. Since the application/driver used Ethernet overhead i

Re: [dpdk-dev] [PATCH v3 01/22] ethdev: fix MTU size exceeds max rx packet length

2021-01-14 Thread Ferruh Yigit
On 1/14/2021 9:45 AM, Steve Yang wrote: Ethdev is using default Ethernet overhead to decide if provided 'max_rx_pkt_len' value is bigger than max (non jumbo) MTU value, and limits it to MAX if it is. Since the application/driver used Ethernet overhead is different than the ethdev one, check resu

[dpdk-dev] [PATCH v3 01/22] ethdev: fix MTU size exceeds max rx packet length

2021-01-14 Thread Steve Yang
Ethdev is using default Ethernet overhead to decide if provided 'max_rx_pkt_len' value is bigger than max (non jumbo) MTU value, and limits it to MAX if it is. Since the application/driver used Ethernet overhead is different than the ethdev one, check result is wrong. If the driver is using Ether