Re: [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-11 Thread Ori Kam
Hi Adrian, > -Original Message- > From: Adrien Mazarguil > Sent: Thursday, October 11, 2018 4:12 PM > To: Ori Kam > Cc: Andrew Rybchenko ; Ferruh Yigit > ; step...@networkplumber.org; Declan Doherty > ; dev@dpdk.org; Dekel Peled > ; Thomas Monjalon ; Nélio > Laranjeiro ; Yongseok Koh >

Re: [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-11 Thread Adrien Mazarguil
Hey Ori, (removing most of the discussion, I'll only reply to the summary) On Thu, Oct 11, 2018 at 08:48:05AM +, Ori Kam wrote: > Hi Adrian, > > Thanks for your comments please see my answer below and inline. > > Due to a very short time limit and the fact that we have more than > 4 patches

Re: [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-11 Thread Ori Kam
Hi Adrian, Thanks for your comments please see my answer below and inline. Due to a very short time limit and the fact that we have more than 4 patches that are based on this we need to close it fast. As I can see there are number of options: * the old approach that neither of us like. And which

Re: [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-10 Thread Adrien Mazarguil
On Wed, Oct 10, 2018 at 01:17:01PM +, Ori Kam wrote: > > -Original Message- > > From: Adrien Mazarguil > > On Wed, Oct 10, 2018 at 09:00:52AM +, Ori Kam wrote: > > > > > > On 10/7/2018 1:57 PM, Ori Kam wrote: > > > > In addtion the parameter to to the encap action is a list of

Re: [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-10 Thread Ori Kam
Hi PSB. > -Original Message- > From: Adrien Mazarguil > Sent: Wednesday, October 10, 2018 3:02 PM > To: Ori Kam > Cc: Andrew Rybchenko ; Ferruh Yigit > ; step...@networkplumber.org; Declan Doherty > ; dev@dpdk.org; Dekel Peled > ; Thomas Monjalon ; Nélio > Laranjeiro ; Yongseok Koh > ; S

Re: [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-10 Thread Adrien Mazarguil
Sorry if I'm a bit late to the discussion, please see below. On Wed, Oct 10, 2018 at 09:00:52AM +, Ori Kam wrote: > > On 10/7/2018 1:57 PM, Ori Kam wrote: > > This series implement the generic L2/L3 tunnel encapsulation actions > > and is based on rfc [1] "add generic L2/L3 tunnel encapsulati

Re: [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-10 Thread Thomas Monjalon
10/10/2018 11:30, Andrew Rybchenko: > It is really bad practice that features are accepted without at least > one implementation/usage. Yes. In future, we should take care of not accepting new API without at least one implementation.

Re: [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-10 Thread Andrew Rybchenko
On 10/10/18 12:00 PM, Ori Kam wrote: -Original Message- From: Andrew Rybchenko Sent: Wednesday, October 10, 2018 9:45 AM To: Ferruh Yigit ; Ori Kam ; step...@networkplumber.org; Adrien Mazarguil ; Declan Doherty Cc: dev@dpdk.org; Dekel Peled ; Thomas Monjalon ; Nélio Laranjeiro ; Yongse

Re: [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-10 Thread Ori Kam
> -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, October 10, 2018 9:45 AM > To: Ferruh Yigit ; Ori Kam ; > step...@networkplumber.org; Adrien Mazarguil > ; Declan Doherty > Cc: dev@dpdk.org; Dekel Peled ; Thomas Monjalon > ; Nélio Laranjeiro ; > Yongseok Koh ; Shahaf Shu

Re: [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-09 Thread Andrew Rybchenko
On 10/9/18 7:48 PM, Ferruh Yigit wrote: On 10/7/2018 1:57 PM, Ori Kam wrote: This series implement the generic L2/L3 tunnel encapsulation actions and is based on rfc [1] "add generic L2/L3 tunnel encapsulation actions" Currenlty the encap/decap actions only support encapsulation of VXLAN and NV

Re: [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-09 Thread Ferruh Yigit
On 10/7/2018 1:57 PM, Ori Kam wrote: > This series implement the generic L2/L3 tunnel encapsulation actions > and is based on rfc [1] "add generic L2/L3 tunnel encapsulation actions" > > Currenlty the encap/decap actions only support encapsulation > of VXLAN and NVGRE L2 packets (L2 encapsulation

[dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-07 Thread Ori Kam
This series implement the generic L2/L3 tunnel encapsulation actions and is based on rfc [1] "add generic L2/L3 tunnel encapsulation actions" Currenlty the encap/decap actions only support encapsulation of VXLAN and NVGRE L2 packets (L2 encapsulation is where the inner packet has a valid Ethernet