[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-27 Thread Yuanhan Liu
On Fri, Sep 23, 2016 at 10:28:23AM +0200, Maxime Coquelin wrote: > + if (vq->desc[desc_indexes[i]].flags & VRING_DESC_F_INDIRECT) { > + desc = (struct vring_desc *)gpa_to_vva(dev, As mentioned before, this would break 32 bit OS build. It should be (struct v

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-27 Thread Maxime Coquelin
On 09/27/2016 06:15 AM, Yuanhan Liu wrote: > On Fri, Sep 23, 2016 at 10:28:23AM +0200, Maxime Coquelin wrote: >> +if (vq->desc[desc_indexes[i]].flags & VRING_DESC_F_INDIRECT) { >> +desc = (struct vring_desc *)gpa_to_vva(dev, > > As mentioned before, this would brea

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-26 Thread Yuanhan Liu
On Mon, Sep 26, 2016 at 03:25:35PM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 26, 2016 at 11:03:54AM +0800, Yuanhan Liu wrote: > > On Fri, Sep 23, 2016 at 01:24:14PM -0700, Stephen Hemminger wrote: > > > On Fri, 23 Sep 2016 21:22:23 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Fri

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-26 Thread Michael S. Tsirkin
On Mon, Sep 26, 2016 at 11:03:54AM +0800, Yuanhan Liu wrote: > On Fri, Sep 23, 2016 at 01:24:14PM -0700, Stephen Hemminger wrote: > > On Fri, 23 Sep 2016 21:22:23 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Sep 23, 2016 at 08:16:09PM +0200, Maxime Coquelin wrote: > > > > > > > > > >

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-26 Thread Yuanhan Liu
On Fri, Sep 23, 2016 at 01:24:14PM -0700, Stephen Hemminger wrote: > On Fri, 23 Sep 2016 21:22:23 +0300 > "Michael S. Tsirkin" wrote: > > > On Fri, Sep 23, 2016 at 08:16:09PM +0200, Maxime Coquelin wrote: > > > > > > > > > On 09/23/2016 08:06 PM, Michael S. Tsirkin wrote: > > > > On Fri, Sep

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Michael S. Tsirkin
On Fri, Sep 23, 2016 at 08:16:09PM +0200, Maxime Coquelin wrote: > > > On 09/23/2016 08:06 PM, Michael S. Tsirkin wrote: > > On Fri, Sep 23, 2016 at 08:02:27PM +0200, Maxime Coquelin wrote: > > > > > > > > > On 09/23/2016 05:49 PM, Michael S. Tsirkin wrote: > > > > On Fri, Sep 23, 2016 at 10:28

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Michael S. Tsirkin
On Fri, Sep 23, 2016 at 08:02:27PM +0200, Maxime Coquelin wrote: > > > On 09/23/2016 05:49 PM, Michael S. Tsirkin wrote: > > On Fri, Sep 23, 2016 at 10:28:23AM +0200, Maxime Coquelin wrote: > > > Indirect descriptors are usually supported by virtio-net devices, > > > allowing to dispatch a larger

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Maxime Coquelin
On 09/23/2016 08:06 PM, Michael S. Tsirkin wrote: > On Fri, Sep 23, 2016 at 08:02:27PM +0200, Maxime Coquelin wrote: >> >> >> On 09/23/2016 05:49 PM, Michael S. Tsirkin wrote: >>> On Fri, Sep 23, 2016 at 10:28:23AM +0200, Maxime Coquelin wrote: Indirect descriptors are usually supported by v

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Maxime Coquelin
On 09/23/2016 05:49 PM, Michael S. Tsirkin wrote: > On Fri, Sep 23, 2016 at 10:28:23AM +0200, Maxime Coquelin wrote: >> Indirect descriptors are usually supported by virtio-net devices, >> allowing to dispatch a larger number of requests. >> >> When the virtio device sends a packet using indirect

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Michael S. Tsirkin
On Fri, Sep 23, 2016 at 10:28:23AM +0200, Maxime Coquelin wrote: > Indirect descriptors are usually supported by virtio-net devices, > allowing to dispatch a larger number of requests. > > When the virtio device sends a packet using indirect descriptors, > only one slot is used in the ring, even f

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Stephen Hemminger
On Fri, 23 Sep 2016 21:22:23 +0300 "Michael S. Tsirkin" wrote: > On Fri, Sep 23, 2016 at 08:16:09PM +0200, Maxime Coquelin wrote: > > > > > > On 09/23/2016 08:06 PM, Michael S. Tsirkin wrote: > > > On Fri, Sep 23, 2016 at 08:02:27PM +0200, Maxime Coquelin wrote: > > > > > > > > > > > > On

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Maxime Coquelin
Indirect descriptors are usually supported by virtio-net devices, allowing to dispatch a larger number of requests. When the virtio device sends a packet using indirect descriptors, only one slot is used in the ring, even for large packets. The main effect is to improve the 0% packet loss benchma