Re: [dpdk-dev] [PATCH v3] net/virtio: fix wrong variable assignment in helper macro

2020-08-19 Thread Vipul Ashri
: Wednesday, 19 August, 2020 0:15 To: Vipul Ashri ; Xia, Chenbo ; dev@dpdk.org; sta...@dpdk.org; Wang, Zhihong ; maxime.coque...@redhat.com Cc: Edwin Leung Subject: Re: [dpdk-dev] [PATCH v3] net/virtio: fix wrong variable assignment in helper macro On 8/14/2020 6:23 AM, Vipul Ashri wrote: > Hi

Re: [dpdk-dev] [PATCH v3] net/virtio: fix wrong variable assignment in helper macro

2020-08-18 Thread Xia, Chenbo
> -Original Message- > From: Vipul Ashri > Sent: Thursday, August 13, 2020 3:29 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; vipul.as...@oracle.com; > edwin.le...@oracle.com; sta...@dpdk.org > Subject: [PATCH v3] net/virtio: fix wrong variable assignment in helper > macro > > Inside Macro A

Re: [dpdk-dev] [PATCH v3] net/virtio: fix wrong variable assignment in helper macro

2020-08-18 Thread Ferruh Yigit
On 8/14/2020 6:23 AM, Vipul Ashri wrote: > Hi All > > I tried twice uploading this same patch but it is still not listed under > http://patches.dpdk.org/project/dpdk/list/. > Please let me know if I am missing something and required to do some > additional steps to submit my patch. Mail list is

Re: [dpdk-dev] [PATCH v3] net/virtio: fix wrong variable assignment in helper macro

2020-08-18 Thread Vipul Ashri
Hi All I tried twice uploading this same patch but it is still not listed under http://patches.dpdk.org/project/dpdk/list/. Please let me know if I am missing something and required to do some additional steps to submit my patch. Thanks to Xia for reviewing this code! Regards Vipul -Orig

[dpdk-dev] [PATCH v3] net/virtio: fix wrong variable assignment in helper macro

2020-08-18 Thread Vipul Ashri
Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always failing as assignment done using var_ having local scope only. This leads to TX packets not going out and found broken due to cleanup malfunctioning. This patch fixes the wrong variable assignment. Fixes: 57f90f894588 ("net/vi

[dpdk-dev] [PATCH v3] net/virtio: fix wrong variable assignment in helper macro

2020-08-18 Thread Vipul Ashri
Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always failing as assignment done using var_ having local scope only. This leads to TX packets not going out and found broken due to cleanup malfunctioning. This patch fixes the wrong variable assignment. Fixes: 57f90f894588 ("net/vi

Re: [dpdk-dev] [PATCH v3] net/virtio: fix wrong variable assignment in helper macro

2020-08-13 Thread Xia, Chenbo
> -Original Message- > From: Vipul Ashri > Sent: Friday, August 14, 2020 12:22 AM > To: dev@dpdk.org > Cc: Xia, Chenbo ; vipul.as...@oracle.com; > edwin.le...@oracle.com; sta...@dpdk.org; Wang, Zhihong > ; maxime.coque...@redhat.com > Subject: [PATCH v3] net/virtio: fix wrong variable ass

Re: [dpdk-dev] [PATCH v3] net/virtio: fix wrong variable assignment in helper macro

2020-08-13 Thread Xia, Chenbo
> -Original Message- > From: Vipul Ashri > Sent: Thursday, August 13, 2020 3:29 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; vipul.as...@oracle.com; > edwin.le...@oracle.com; sta...@dpdk.org > Subject: [PATCH v3] net/virtio: fix wrong variable assignment in helper > macro > > Inside Macro AS