Re: [dpdk-dev] [PATCH v3] net/tap: fix flow and port commands

2017-09-18 Thread Pascal Mazon
Hi, Your reasons to keep *dev in pmd_internals are good enough for me! The rest of the patch looks fine. Acked-by: Pascal Mazon On 17/09/2017 00:32, Ophir Munk wrote: > This commit fixes two bugs related to tap devices. The first bug occurs > when executing in testpmd the following flow rule a

[dpdk-dev] [PATCH v3] net/tap: fix flow and port commands

2017-09-16 Thread Ophir Munk
This commit fixes two bugs related to tap devices. The first bug occurs when executing in testpmd the following flow rule assuming tap device has 4 rx and tx pair queues "flow create 0 ingress pattern eth / end actions queue index 5 / end" This command will report on success and will print ""Flow r