Re: [dpdk-dev] [PATCH v3] net/tap: add queues when attaching from secondary process

2018-08-23 Thread Ferruh Yigit
On 7/20/2018 12:15 PM, Thomas Monjalon wrote: > From: Raslan Darawsheh > > In the case the device is created by the primary process, > the secondary must request some file descriptors to attach the queues. > The file descriptors are shared via IPC Unix socket. > > Thanks to the IPC synchronizati

Re: [dpdk-dev] [PATCH v3] net/tap: add queues when attaching from secondary process

2018-07-21 Thread Wiles, Keith
> On Jul 20, 2018, at 4:51 PM, Thomas Monjalon wrote: > > 20/07/2018 17:35, Wiles, Keith: >>> On Jul 20, 2018, at 4:15 AM, Thomas Monjalon wrote: >>> + /* FIXME: handle replies.nb_received > 1 */ >> >> I am not a big fan of having TODO or FIXME comments in the code. > > What don't you lik

Re: [dpdk-dev] [PATCH v3] net/tap: add queues when attaching from secondary process

2018-07-20 Thread Thomas Monjalon
20/07/2018 17:35, Wiles, Keith: > > On Jul 20, 2018, at 4:15 AM, Thomas Monjalon wrote: > > + /* FIXME: handle replies.nb_received > 1 */ > > I am not a big fan of having TODO or FIXME comments in the code. What don't you like in such comments? > Can we remove them and just describe the probl

Re: [dpdk-dev] [PATCH v3] net/tap: add queues when attaching from secondary process

2018-07-20 Thread Wiles, Keith
> On Jul 20, 2018, at 4:15 AM, Thomas Monjalon wrote: > > From: Raslan Darawsheh > > In the case the device is created by the primary process, > the secondary must request some file descriptors to attach the queues. > The file descriptors are shared via IPC Unix socket. > > Thanks to the IP

[dpdk-dev] [PATCH v3] net/tap: add queues when attaching from secondary process

2018-07-20 Thread Thomas Monjalon
From: Raslan Darawsheh In the case the device is created by the primary process, the secondary must request some file descriptors to attach the queues. The file descriptors are shared via IPC Unix socket. Thanks to the IPC synchronization, the secondary process is now able to do Rx/Tx on a TAP c