Re: [dpdk-dev] [PATCH v3] net/bonding: add add/remove mac addrs

2018-06-20 Thread Alex Kiselev
> Please see comments below. From: Matan Azrad >> +/* >> + * Remove additional MAC addresses from the slave */ int >> +slave_remove_mac_addresses(struct rte_eth_dev *bonded_eth_dev, >> + uint16_t slave_port_id) >> +{ >> + int i, ret = 0; >> + struct ether_addr *mac_addr; >>

Re: [dpdk-dev] [PATCH v3] net/bonding: add add/remove mac addrs

2018-06-19 Thread Matan Azrad
From: Alex Kiselev > Hi Matan. > > > Hi Alex > > > Please see comments below. > > > >> + > >> + ret = rte_eth_dev_mac_addr_add(slave_port_id, mac_addr, 0); > >> + if (ret < 0) { > >> + /* rollback */ > >> + for (i--; i > 0; i--

Re: [dpdk-dev] [PATCH v3] net/bonding: add add/remove mac addrs

2018-06-19 Thread Alex Kiselev
Hi Matan. > Hi Alex > Please see comments below. >> + >> + ret = rte_eth_dev_mac_addr_add(slave_port_id, mac_addr, 0); >> + if (ret < 0) { >> + /* rollback */ >> + for (i--; i > 0; i--) >> + > In case of failure in the first mac a

Re: [dpdk-dev] [PATCH v3] net/bonding: add add/remove mac addrs

2018-06-19 Thread Matan Azrad
Hi Alex Please see comments below. From: Alex Kiselev > add functions to add/remove MAC addresses > Signed-off-by: Alex Kiselev > --- > drivers/net/bonding/rte_eth_bond_api.c | 12 ++- > drivers/net/bonding/rte_eth_bond_pmd.c | 127 > - > drivers/net/bonding

[dpdk-dev] [PATCH v3] net/bonding: add add/remove mac addrs

2018-06-19 Thread Alex Kiselev
add functions to add/remove MAC addresses Signed-off-by: Alex Kiselev --- drivers/net/bonding/rte_eth_bond_api.c | 12 ++- drivers/net/bonding/rte_eth_bond_pmd.c | 127 - drivers/net/bonding/rte_eth_bond_private.h | 8 ++ 3 files changed, 142 insertions(+),