dk-dev] [PATCH v3] hash: added a new API to hash to query
> key id
>
> "Van Haaren, Harry" writes:
>
> >> -Original Message-
> >> From: Van Haaren, Harry
> >> Sent: Tuesday, November 26, 2019 1:19 PM
> >> To: Aaron Conole ; Th
; ; Yigit, Ferruh ; Thakur,
>> Sham Singh ; David Marchand
>>
>> Subject: Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query
>> key id
>>
>> Aaron Conole writes:
>>
>> > Thomas Monjalon writes:
>> >
>> >&g
"Van Haaren, Harry" writes:
>> -Original Message-
>> From: Van Haaren, Harry
>> Sent: Tuesday, November 26, 2019 1:19 PM
>> To: Aaron Conole ; Thomas Monjalon
>
>
>
>> > EAL: Test assert service_lcore_en_dis_able line 487 failed: Ex-service
>> core
>> > function call had no effect.
>> >
> -Original Message-
> From: Van Haaren, Harry
> Sent: Tuesday, November 26, 2019 1:19 PM
> To: Aaron Conole ; Thomas Monjalon
> > EAL: Test assert service_lcore_en_dis_able line 487 failed: Ex-service
> core
> > function call had no effect.
> >
> > So I'll spend some time in this area,
ject: Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query
> key id
>
> Aaron Conole writes:
>
> > Thomas Monjalon writes:
> >
> >>> From: Aaron Conole
> >>> > - if (!service_valid(id))
> >>> > + if (id &g
Aaron Conole writes:
> Thomas Monjalon writes:
>
>>> From: Aaron Conole
>>> > - if (!service_valid(id))
>>> > + if (id >= RTE_SERVICE_NUM_MAX || !service_valid(id))
>>
>> Why not adding this check in service_valid()?
>
> I think the best fix is to use SERVICE_VALID_GET_OR_ERR_RET() in these
> p
Hi, Amber, Thanks for the patch! A bit comment inlined:
>-Original Message-
>From: Amber, Kumar
>Sent: Monday, November 25, 2019 3:08 AM
>To: dev@dpdk.org
>Cc: Wang, Yipeng1
>Subject: [PATCH v3] hash: added a new API to hash to query key id
>
>Adding new API function to query the maximum
Thomas Monjalon writes:
>> From: Aaron Conole
>> > - if (!service_valid(id))
>> > + if (id >= RTE_SERVICE_NUM_MAX || !service_valid(id))
>
> Why not adding this check in service_valid()?
I think the best fix is to use SERVICE_VALID_GET_OR_ERR_RET() in these
places. For this, I at least want
> From: Aaron Conole
> > - if (!service_valid(id))
> > + if (id >= RTE_SERVICE_NUM_MAX || !service_valid(id))
Why not adding this check in service_valid()?
t: Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query
> key id
>
> "Amber, Kumar" writes:
>
> > Hi all ,
> >
> > I want to report random untouched unit test cases failed by Jenkins
> > . pls can you guys check why it is unstable ?
return -EINVAL;
struct core_state *cs = &lcore_states[rte_lcore_id()];
---
Harry?
> Regards
> Amber
>
> -Original Message-
> From: dev On Behalf Of Kumar Amber
> Sent: Monday, November 25, 2019 4:38 PM
> To: dev@dpdk.org
> Cc: Wang, Yipeng1
> Su
pdk.org/archives/test-report/2019-November/109120.html
>
> Regards
> Amber
>
> -Original Message-
> From: dev On Behalf Of Kumar Amber
> Sent: Monday, November 25, 2019 4:38 PM
> To: dev@dpdk.org
> Cc: Wang, Yipeng1
> Subject: [dpdk-dev] [PATCH v3] hash: added a
Behalf Of Kumar Amber
Sent: Monday, November 25, 2019 4:38 PM
To: dev@dpdk.org
Cc: Wang, Yipeng1
Subject: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id
Adding new API function to query the maximum key ID that could possibly
returned by rte_hash_add_key and
Adding new API function to query the maximum key ID
that could possibly returned by rte_hash_add_key and
rte_hash_add_key_with_hash. When RTE_HASH_EXTRA_FLAGS_MULTI_WRITER_ADD
is set, the maximum key id is larger than the entry count specified
by the user.
Signed-off-by: Kumar Amber
---
lib/libr
Adding new API function to query the maximum key ID
that could possibly returned by rte_hash_add_key and
rte_hash_add_key_with_hash. When RTE_HASH_EXTRA_FLAGS_MULTI_WRITER_ADD
is set, the maximum key id is larger than the entry count specified
by the user.
Signed-off-by: Kumar Amber
---
lib/libr
15 matches
Mail list logo
