Re: [dpdk-dev] [PATCH v3] ethdev: cleanup device ops struct whitespace

2016-12-22 Thread Thomas Monjalon
2016-12-22 15:16, Ferruh Yigit: > On 12/22/2016 3:10 PM, Jan Blunck wrote: > > On Thu, Dec 22, 2016 at 2:10 PM, Ferruh Yigit > > wrote: > >> - Grouped related items using empty lines > > > > Reordering fields of a struct is breaking ABI. We should bump the > > library version now. > > You are r

Re: [dpdk-dev] [PATCH v3] ethdev: cleanup device ops struct whitespace

2016-12-22 Thread Jan Blunck
On Thu, Dec 22, 2016 at 2:10 PM, Ferruh Yigit wrote: > - Grouped related items using empty lines Reordering fields of a struct is breaking ABI. We should bump the library version now. > - Aligned arguments to same column > - All item comments that doesn't fit same line are placed blow the item

Re: [dpdk-dev] [PATCH v3] ethdev: cleanup device ops struct whitespace

2016-12-22 Thread Ferruh Yigit
On 12/22/2016 3:10 PM, Jan Blunck wrote: > On Thu, Dec 22, 2016 at 2:10 PM, Ferruh Yigit wrote: >> - Grouped related items using empty lines > > Reordering fields of a struct is breaking ABI. We should bump the > library version now. You are right, sorry missed that. Intention was not to break t

Re: [dpdk-dev] [PATCH v3] ethdev: cleanup device ops struct whitespace

2016-12-22 Thread Thomas Monjalon
2016-12-22 13:10, Ferruh Yigit: > - Grouped related items using empty lines > - Aligned arguments to same column > - All item comments that doesn't fit same line are placed blow the item > itself > - Moved some comments to same line if overall line < 100 chars > > Signed-off-by: Ferruh Yigit A

[dpdk-dev] [PATCH v3] ethdev: cleanup device ops struct whitespace

2016-12-22 Thread Ferruh Yigit
- Grouped related items using empty lines - Aligned arguments to same column - All item comments that doesn't fit same line are placed blow the item itself - Moved some comments to same line if overall line < 100 chars Signed-off-by: Ferruh Yigit --- - ! This patch has the problem of trashing