Re: [dpdk-dev] [PATCH v2 6/7] net/mlx4: convert to new Tx offloads API

2018-01-09 Thread Nelio Laranjeiro
Hi Shahaf, On Thu, Jan 04, 2018 at 11:55:17AM +, Shahaf Shuler wrote: > Hi Adrien and Nelio, > > See below comment regarding your output on the offload check. > Rest of the comments were accepted. > > Wednesday, January 3, 2018 7:29 PM, Adrien Mazarguil : > > [...] > > > > > > +{ > > > +

Re: [dpdk-dev] [PATCH v2 6/7] net/mlx4: convert to new Tx offloads API

2018-01-04 Thread Shahaf Shuler
Hi Adrien and Nelio, See below comment regarding your output on the offload check. Rest of the comments were accepted. Wednesday, January 3, 2018 7:29 PM, Adrien Mazarguil : [...] > > > +{ > > + uint64_t port_offloads = priv->dev->data- > >dev_conf.txmode.offloads; > > + uint64_t port_supp

Re: [dpdk-dev] [PATCH v2 6/7] net/mlx4: convert to new Tx offloads API

2018-01-03 Thread Adrien Mazarguil
Hi Shahaf, Some relatively minor nits mostly unrelated to functionality, please see below. On Wed, Jan 03, 2018 at 09:16:16AM +0200, Shahaf Shuler wrote: > Ethdev Tx offloads API has changed since: > > commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") > > This commit support the n

[dpdk-dev] [PATCH v2 6/7] net/mlx4: convert to new Tx offloads API

2018-01-02 Thread Shahaf Shuler
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new Tx offloads API. Signed-off-by: Shahaf Shuler --- drivers/net/mlx4/mlx4_ethdev.c | 7 +--- drivers/net/mlx4/mlx4_rxtx.h | 1 + drivers/net/mlx4/mlx4_txq.c