Re: [dpdk-dev] [PATCH v2 5/7] eal: bring forward init of interrupt handling

2018-07-13 Thread David Marchand
On Fri, Jul 13, 2018 at 11:10 AM, Tiwei Bie wrote: > On Fri, Jul 13, 2018 at 10:09:42AM +0200, David Marchand wrote: > [...] >> Well, there was an issue vith virtio at one time (interrupt handler >> did not have the right iopl for virtio callback). >> http://git.dpdk.org/dpdk/commit/lib/librte_eal

Re: [dpdk-dev] [PATCH v2 5/7] eal: bring forward init of interrupt handling

2018-07-13 Thread Tiwei Bie
On Fri, Jul 13, 2018 at 10:09:42AM +0200, David Marchand wrote: [...] > Well, there was an issue vith virtio at one time (interrupt handler > did not have the right iopl for virtio callback). > http://git.dpdk.org/dpdk/commit/lib/librte_eal/linuxapp/eal/eal.c?id=fd6949c55c9a48e81c625138679159829d51

Re: [dpdk-dev] [PATCH v2 5/7] eal: bring forward init of interrupt handling

2018-07-13 Thread David Marchand
On Fri, Jul 13, 2018 at 12:36 AM, Thomas Monjalon wrote: > I am almost sure it will bring regressions. > > Please think again about the consequences of initializing interrupt thread > before affinity setting, memory init, device init. Well, there was an issue vith virtio at one time (interrupt ha

Re: [dpdk-dev] [PATCH v2 5/7] eal: bring forward init of interrupt handling

2018-07-13 Thread Burakov, Anatoly
On 12-Jul-18 11:36 PM, Thomas Monjalon wrote: 26/06/2018 12:53, Anatoly Burakov: From: Jianfeng Tan Next commit will make asynchronous IPC requests rely on alarm API, which in turn relies on interrupts to work. Therefore, move the EAL interrupt initialization before IPC initialization to avoid

Re: [dpdk-dev] [PATCH v2 5/7] eal: bring forward init of interrupt handling

2018-07-12 Thread Thomas Monjalon
26/06/2018 12:53, Anatoly Burakov: > From: Jianfeng Tan > > Next commit will make asynchronous IPC requests rely on alarm API, > which in turn relies on interrupts to work. Therefore, move the EAL > interrupt initialization before IPC initialization to avoid breaking > IPC in the next commit. >

[dpdk-dev] [PATCH v2 5/7] eal: bring forward init of interrupt handling

2018-06-26 Thread Anatoly Burakov
From: Jianfeng Tan Next commit will make asynchronous IPC requests rely on alarm API, which in turn relies on interrupts to work. Therefore, move the EAL interrupt initialization before IPC initialization to avoid breaking IPC in the next commit. Signed-off-by: Jianfeng Tan Signed-off-by: Anato