Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-14 Thread Matan Azrad
Hi > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Thursday, December 14, 2017 3:27 PM > To: Matan Azrad > Cc: Adrien Mazarguil ; Thomas Monjalon > ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v2 4/4] net/failsafe: fix removed device handling >

Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-14 Thread Gaëtan Rivet
On Thu, Dec 14, 2017 at 01:07:31PM +, Matan Azrad wrote: > Hi Gaetan > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Thursday, December 14, 2017 12:49 PM > > To: Matan Azrad > > Cc: Adrien Mazarguil ; Thomas Monjalon > > ; dev@dpdk.org; sta...

Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-14 Thread Matan Azrad
Hi Gaetan > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Thursday, December 14, 2017 12:49 PM > To: Matan Azrad > Cc: Adrien Mazarguil ; Thomas Monjalon > ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v2 4/4] net/failsafe: fix removed device hand

Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-14 Thread Gaëtan Rivet
On Thu, Dec 14, 2017 at 10:40:22AM +, Matan Azrad wrote: > Hi Gaetan > > > > > > > If you add this check in the iterator itself, you would skip removed > > > devices before attempting operating upon them, right? > > > > > > Then it should probably help with your issue, unless you tested it

Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-14 Thread Matan Azrad
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, December 13, 2017 7:09 PM > To: Gaëtan Rivet ; Matan Azrad > > Cc: Adrien Mazarguil ; dev@dpdk.org; > sta...@dpdk.org > Subject: Re: [PATCH v2 4/4] net/failsafe: fix removed device handling > >

Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-14 Thread Matan Azrad
Hi Gaetan > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Wednesday, December 13, 2017 11:56 PM > To: Matan Azrad > Cc: Adrien Mazarguil ; Thomas Monjalon > ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v2 4/4] net/failsafe: fix removed device han

Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-13 Thread Gaëtan Rivet
Hi again Matan, On Wed, Dec 13, 2017 at 05:09:16PM +0100, Gaëtan Rivet wrote: > On Wed, Dec 13, 2017 at 03:48:46PM +, Matan Azrad wrote: > > Hi Gaetan > > Thanks for the review. > > Some comments.. > > > > > -Original Message- > > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] >

Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-13 Thread Thomas Monjalon
13/12/2017 17:09, Gaëtan Rivet: > On Wed, Dec 13, 2017 at 03:48:46PM +, Matan Azrad wrote: > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > > > Fixes: a46f8d5 ("net/failsafe: add fail-safe PMD") > > > > Fixes: b737a1e ("net/failsafe: support flow API") > > > > Cc: sta...@dpdk.org > >

Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-13 Thread Gaëtan Rivet
On Wed, Dec 13, 2017 at 03:48:46PM +, Matan Azrad wrote: > Hi Gaetan > Thanks for the review. > Some comments.. > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Wednesday, December 13, 2017 5:17 PM > > To: Matan Azrad > > Cc: Adrien Mazarguil ;

Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-13 Thread Matan Azrad
Hi Gaetan Thanks for the review. Some comments.. > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Wednesday, December 13, 2017 5:17 PM > To: Matan Azrad > Cc: Adrien Mazarguil ; Thomas Monjalon > ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v2 4/4

Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-13 Thread Gaëtan Rivet
Hi Matan, On Wed, Dec 13, 2017 at 02:29:30PM +, Matan Azrad wrote: > There is time between the physical removal of the device until > sub-device PMDs get a RMV interrupt. At this time DPDK PMDs and > applications still don't know about the removal and may call sub-device > control operation wh

[dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-13 Thread Matan Azrad
There is time between the physical removal of the device until sub-device PMDs get a RMV interrupt. At this time DPDK PMDs and applications still don't know about the removal and may call sub-device control operation which should return an error. In previous code this error is reported to the appl