Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: fix build by enabling trace compilation

2020-04-26 Thread Dmitry Kozlyuk
On 2020-04-26 17:38 GMT+0200 Thomas Monjalon wrote: > I think this patch is doing too many things at once. > Why not just disabling tracing on Windows for now, > and apply proper patches for memory management, timer, endianness, etc > in 20.08? Sounds reasonable since tracing cannot be fully suppo

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: fix build by enabling trace compilation

2020-04-26 Thread Thomas Monjalon
I think this patch is doing too many things at once. Why not just disabling tracing on Windows for now, and apply proper patches for memory management, timer, endianness, etc in 20.08? Some cosmetic comments below, 26/04/2020 17:28, Dmitry Kozlyuk: > Replace clock_gettime(CLOCK_REALTIME) with C11

[dpdk-dev] [PATCH v2 3/3] eal/windows: fix build by enabling trace compilation

2020-04-26 Thread Dmitry Kozlyuk
Replace clock_gettime(CLOCK_REALTIME) with C11 timespec_get(). Implementation is provided for MinGW-w64 that misses this function. Provide minimum viable implementations of malloc and timer functions used by tracing. Regex stubs are already present in Windows EAL. Fixes: 185b7dc1d467 ("trace: sav