Re: [dpdk-dev] [PATCH v2 2/4] mempool: use generic memory management

2020-06-02 Thread Andrew Rybchenko
On 6/2/20 12:14 AM, Thomas Monjalon wrote: > 01/06/2020 21:59, Dmitry Kozlyuk: >> 1. What do you think about changing rte_ to rte_eal_ prefix for memory >> management wrappers in MM series as Andrew Rybchenko suggested for v1? Since >> the functions are DPDK-internal, this sounds reasonable to me.

Re: [dpdk-dev] [PATCH v2 2/4] mempool: use generic memory management

2020-06-01 Thread Thomas Monjalon
01/06/2020 21:59, Dmitry Kozlyuk: > 1. What do you think about changing rte_ to rte_eal_ prefix for memory > management wrappers in MM series as Andrew Rybchenko suggested for v1? Since > the functions are DPDK-internal, this sounds reasonable to me. For lib-internal function, the prefix should no

Re: [dpdk-dev] [PATCH v2 2/4] mempool: use generic memory management

2020-06-01 Thread Ranjit Menon
On 6/1/2020 12:59 PM, Dmitry Kozlyuk wrote: On Mon, 1 Jun 2020 13:31:37 +0300 Fady Bader wrote: [snip] /* populate the mempool with an anonymous mapping */ @@ -740,20 +739,20 @@ rte_mempool_populate_anon(struct rte_mempool *mp) } /* get chunk of virtually continuous memory */

Re: [dpdk-dev] [PATCH v2 2/4] mempool: use generic memory management

2020-06-01 Thread Dmitry Kozlyuk
On Mon, 1 Jun 2020 13:31:37 +0300 Fady Bader wrote: [snip] > /* populate the mempool with an anonymous mapping */ > @@ -740,20 +739,20 @@ rte_mempool_populate_anon(struct rte_mempool *mp) > } > > /* get chunk of virtually continuous memory */ > - addr = mmap(NULL, size, PROT_R

[dpdk-dev] [PATCH v2 2/4] mempool: use generic memory management

2020-06-01 Thread Fady Bader
mempool used Unix memory management calls, which are not supported on Windows. Used generic memory management instead. Signed-off-by: Fady Bader --- lib/librte_mempool/rte_mempool.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/lib/librte_mempool/rte