Re: [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC

2018-04-16 Thread Thomas Monjalon
16/04/2018 19:23, Ferruh Yigit: > On 4/1/2018 8:10 AM, Shahaf Shuler wrote: > > Thursday, March 29, 2018 4:32 PM, Ferruh Yigit: > >> On 3/29/2018 8:56 AM, Shahaf Shuler wrote: > >>> Thursday, March 29, 2018 10:43 AM, Thomas Monjalon: > 29/03/2018 07:38, Shahaf Shuler: > > Wednesday, March

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC

2018-04-16 Thread Ferruh Yigit
On 4/1/2018 8:10 AM, Shahaf Shuler wrote: > Thursday, March 29, 2018 4:32 PM, Ferruh Yigit: >> On 3/29/2018 8:56 AM, Shahaf Shuler wrote: >>> Thursday, March 29, 2018 10:43 AM, Thomas Monjalon: 29/03/2018 07:38, Shahaf Shuler: > Wednesday, March 21, 2018 9:48 PM, Ferruh Yigit: >> DEV_R

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC

2018-04-01 Thread Shahaf Shuler
Thursday, March 29, 2018 4:32 PM, Ferruh Yigit: > On 3/29/2018 8:56 AM, Shahaf Shuler wrote: > > Thursday, March 29, 2018 10:43 AM, Thomas Monjalon: > >> 29/03/2018 07:38, Shahaf Shuler: > >>> Wednesday, March 21, 2018 9:48 PM, Ferruh Yigit: > DEV_RX_OFFLOAD_KEEP_CRC offload flag added. > > >

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC

2018-03-29 Thread Ferruh Yigit
On 3/29/2018 8:56 AM, Shahaf Shuler wrote: > Thursday, March 29, 2018 10:43 AM, Thomas Monjalon: >> 29/03/2018 07:38, Shahaf Shuler: >>> Wednesday, March 21, 2018 9:48 PM, Ferruh Yigit: DEV_RX_OFFLOAD_KEEP_CRC offload flag added. DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more rel

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC

2018-03-29 Thread Shahaf Shuler
Thursday, March 29, 2018 10:43 AM, Thomas Monjalon: > 29/03/2018 07:38, Shahaf Shuler: > > Wednesday, March 21, 2018 9:48 PM, Ferruh Yigit: > > > DEV_RX_OFFLOAD_KEEP_CRC offload flag added. > > > > > > DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release but > > > default behavior in PMDs is

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC

2018-03-29 Thread Thomas Monjalon
29/03/2018 07:38, Shahaf Shuler: > Wednesday, March 21, 2018 9:48 PM, Ferruh Yigit: > > DEV_RX_OFFLOAD_KEEP_CRC offload flag added. > > > > DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release but default > > behavior in PMDs is to strip the CRC independent from this flag. > > > > Until DEV

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC

2018-03-28 Thread Shahaf Shuler
Wednesday, March 21, 2018 9:48 PM, Ferruh Yigit: > DEV_RX_OFFLOAD_KEEP_CRC offload flag added. > > DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release but default > behavior in PMDs is to strip the CRC independent from this flag. > > Until DEV_RX_OFFLOAD_CRC_STRIP flag is removed: > - Sett

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC

2018-03-21 Thread Thomas Monjalon
21/03/2018 20:47, Ferruh Yigit: > DEV_RX_OFFLOAD_KEEP_CRC offload flag added. > > DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release but default > behavior in PMDs is to strip the CRC independent from this flag. > > Until DEV_RX_OFFLOAD_CRC_STRIP flag is removed: > - Setting both KEEP_CRC

[dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC

2018-03-21 Thread Ferruh Yigit
DEV_RX_OFFLOAD_KEEP_CRC offload flag added. DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release but default behavior in PMDs is to strip the CRC independent from this flag. Until DEV_RX_OFFLOAD_CRC_STRIP flag is removed: - Setting both KEEP_CRC & CRC_STRIP is INVALID - Setting only CRC_STR