[dpdk-dev] [PATCH v2 2/2] drivers/net/vmxnet3: add ethdev functions

2016-03-07 Thread Remy Horton
On 07/03/2016 16:07, Stephen Hemminger wrote: >> That version doesn't include a MAC address sanity check - is such a >> check redundant (or incorrect) in this case? >> >> ..Remy > > That belongs in common code, not in each driver. That differs from previous feedback for a different driver, where

[dpdk-dev] [PATCH v2 2/2] drivers/net/vmxnet3: add ethdev functions

2016-03-07 Thread Remy Horton
On 04/03/2016 20:34, Stephen Hemminger wrote: > On Fri, 4 Mar 2016 15:25:24 + > Remy Horton wrote: > >> Implements driver support for setting of MAC address. >> >> Signed-off-by: Remy Horton [..] > The version I posted is simpler and reuses existing code paths. > That version doesn't inclu

[dpdk-dev] [PATCH v2 2/2] drivers/net/vmxnet3: add ethdev functions

2016-03-07 Thread Stephen Hemminger
On Mon, 07 Mar 2016 17:06:20 + Remy Horton wrote: > > > On 07/03/2016 16:07, Stephen Hemminger wrote: > >> That version doesn't include a MAC address sanity check - is such a > >> check redundant (or incorrect) in this case? > >> > >> ..Remy > > > > That belongs in common code, not in each

[dpdk-dev] [PATCH v2 2/2] drivers/net/vmxnet3: add ethdev functions

2016-03-07 Thread Stephen Hemminger
On Mon, 07 Mar 2016 12:26:13 + Remy Horton wrote: > > On 04/03/2016 20:34, Stephen Hemminger wrote: > > On Fri, 4 Mar 2016 15:25:24 + > > Remy Horton wrote: > > > >> Implements driver support for setting of MAC address. > >> > >> Signed-off-by: Remy Horton > [..] > > The version I pos

[dpdk-dev] [PATCH v2 2/2] drivers/net/vmxnet3: add ethdev functions

2016-03-04 Thread Yong Wang
On 3/4/16, 7:25 AM, "Remy Horton" wrote: >Implements driver support for setting of MAC address. > >Signed-off-by: Remy Horton Acked-by: Yong Wang mac_hi is not initialized so the upper 16bits are random when calling VMXNET3_WRITE_BAR1_REG(). The handler of the mac changing ignores them so i

[dpdk-dev] [PATCH v2 2/2] drivers/net/vmxnet3: add ethdev functions

2016-03-04 Thread Remy Horton
Implements driver support for setting of MAC address. Signed-off-by: Remy Horton --- doc/guides/rel_notes/release_16_04.rst | 4 drivers/net/vmxnet3/vmxnet3_ethdev.c | 19 +++ 2 files changed, 23 insertions(+) diff --git a/doc/guides/rel_notes/release_16_04.rst b/doc/gu

[dpdk-dev] [PATCH v2 2/2] drivers/net/vmxnet3: add ethdev functions

2016-03-04 Thread Stephen Hemminger
On Fri, 4 Mar 2016 15:25:24 + Remy Horton wrote: > Implements driver support for setting of MAC address. > > Signed-off-by: Remy Horton > --- > doc/guides/rel_notes/release_16_04.rst | 4 > drivers/net/vmxnet3/vmxnet3_ethdev.c | 19 +++ > 2 files changed, 23 insert