Re: [dpdk-dev] [PATCH v2 2/2] buildtools: check symbol maps in developer mode

2021-05-13 Thread David Marchand
On Wed, May 12, 2021 at 10:38 PM Thomas Monjalon wrote: > > 12/05/2021 22:24, Thomas Monjalon: > > > > Hook check-symbol-maps.sh in the symbol check when in developer mode to > > > > help developers catch issues before submitting their changes. > > > > > > > > Signed-off-by: David Marchand > > >

Re: [dpdk-dev] [PATCH v2 2/2] buildtools: check symbol maps in developer mode

2021-05-12 Thread Thomas Monjalon
12/05/2021 22:24, Thomas Monjalon: > > > Hook check-symbol-maps.sh in the symbol check when in developer mode to > > > help developers catch issues before submitting their changes. > > > > > > Signed-off-by: David Marchand > > +1 > > > > Reviewed-by: Ray Kinsella > > Series applied, thanks Oo

Re: [dpdk-dev] [PATCH v2 2/2] buildtools: check symbol maps in developer mode

2021-05-12 Thread Thomas Monjalon
> > Hook check-symbol-maps.sh in the symbol check when in developer mode to > > help developers catch issues before submitting their changes. > > > > Signed-off-by: David Marchand > +1 > > Reviewed-by: Ray Kinsella Series applied, thanks

Re: [dpdk-dev] [PATCH v2 2/2] buildtools: check symbol maps in developer mode

2021-05-06 Thread Kinsella, Ray
On 05/05/2021 15:30, David Marchand wrote: > Hook check-symbol-maps.sh in the symbol check when in developer mode to > help developers catch issues before submitting their changes. > > Signed-off-by: David Marchand > --- > Changes since v1: > - now that we have the developer mode, added this c

[dpdk-dev] [PATCH v2 2/2] buildtools: check symbol maps in developer mode

2021-05-05 Thread David Marchand
Hook check-symbol-maps.sh in the symbol check when in developer mode to help developers catch issues before submitting their changes. Signed-off-by: David Marchand --- Changes since v1: - now that we have the developer mode, added this check in the build process, --- buildtools/check-symbols.