[dpdk-dev] [PATCH v2 14/17] e1000: clean log messages

2014-09-02 Thread David Marchand
On Tue, Sep 2, 2014 at 9:05 PM, Jay Rolette wrote: > Couple of minor nits noted. The bigger feedback would be that if you could > keep the "whitespace / line-wrapping / formatting" only changes in separate > patches, these reviews would be easier to get through. > Hum, indeed, I should have done

[dpdk-dev] [PATCH v2 14/17] e1000: clean log messages

2014-09-02 Thread Jay Rolette
Couple of minor nits noted. The bigger feedback would be that if you could keep the "whitespace / line-wrapping / formatting" only changes in separate patches, these reviews would be easier to get through. Jay On Mon, Sep 1, 2014 at 5:24 AM, David Marchand wrote: > Clean log messages: > - remo

[dpdk-dev] [PATCH v2 14/17] e1000: clean log messages

2014-09-01 Thread David Marchand
Clean log messages: - remove leading \n in some messages, - remove trailing \n in some messages, - split multi lines messages, - replace some PMD_INIT_LOG(DEBUG, "some_func") with PMD_INIT_FUNC_TRACE(). Signed-off-by: David Marchand --- lib/librte_pmd_e1000/e1000_logs.h |4 +- lib/librte_pmd