Thursday, March 21, 2019 3:52 PM, Ananyev, Konstantin:
> Subject: RE: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw
> Tx offload value
>
> Hi Shahaf,
>
> > Hi Konstantin,
> >
> > Wednesday, March 20, 2019 8:47 PM, Konstantin Ananyev:
> >
> -Original Message-
> From: Wiles, Keith
> Sent: Wednesday, March 20, 2019 5:53 PM
> To: Ananyev, Konstantin
> Cc: dpdk-dev ; akhil.go...@nxp.com; olivier.m...@6wind.com
> Subject: Re: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx
> offload valu
Hi Shahaf,
> Hi Konstantin,
>
> Wednesday, March 20, 2019 8:47 PM, Konstantin Ananyev:
> > Subject: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx
> > offload value
> >
> > Operations to set/update bit-fields often cause compilers to generate
Hi Konstantin,
Wednesday, March 20, 2019 8:47 PM, Konstantin Ananyev:
> Subject: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx
> offload value
>
> Operations to set/update bit-fields often cause compilers to generate
> suboptimal code.
> To help avoid
>
> +static inline uint64_t
I like this idea. I prefer to add __rte_always_inline for this
function.
> +rte_mbuf_tx_offload(uint64_t il2, uint64_t il3, uint64_t il4,
> uint64_t tso,
> + uint64_t ol3, uint64_t ol2)
> +{
> + return il2 << RTE_MBUF_L2_LEN_OFS |
> + il3 << RTE_MB
Operations to set/update bit-fields often cause compilers
to generate suboptimal code.
To help avoid such situation for tx_offload fields:
introduce new enum for tx_offload bit-fields lengths and offsets,
and new function to generate raw tx_offload value.
Signed-off-by: Konstantin Ananyev
---
li
> On Mar 20, 2019, at 10:24 AM, Konstantin Ananyev
> wrote:
>
> Operations to set/update bit-fields often cause compilers
> to generate suboptimal code.
> To help avoid such situation for tx_offload fields:
> introduce new enum for tx_offload bit-fields lengths and offsets,
> and new function
Operations to set/update bit-fields often cause compilers
to generate suboptimal code.
To help avoid such situation for tx_offload fields:
introduce new enum for tx_offload bit-fields lengths and offsets,
and new function to generate raw tx_offload value.
Signed-off-by: Konstantin Ananyev
---
li
8 matches
Mail list logo
