Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-10-10 Thread Dan Gora
On Wed, Oct 10, 2018 at 11:09 AM Ferruh Yigit wrote: > > Yes, I understand that.. As I pointed out previously, if there is no > > physical device which corresponds to this KNI interface, the > > application can: > > > > 1) Not use this API at all, just as they do now. > > This API has nothing wit

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-10-10 Thread Ferruh Yigit
On 10/3/2018 8:07 PM, Dan Gora wrote: > On Fri, Sep 28, 2018 at 5:03 AM Ferruh Yigit wrote: >> >> On 9/28/2018 12:51 AM, Dan Gora wrote: >>> On Thu, Sep 27, 2018 at 8:44 PM, Ferruh Yigit >>> wrote: > Well, yes the link_status (link up, link down) _is_ applied to the KNI > interface. Whe

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-10-03 Thread Dan Gora
On Fri, Sep 28, 2018 at 5:03 AM Ferruh Yigit wrote: > > On 9/28/2018 12:51 AM, Dan Gora wrote: > > On Thu, Sep 27, 2018 at 8:44 PM, Ferruh Yigit > > wrote: > >>> Well, yes the link_status (link up, link down) _is_ applied to the KNI > >>> interface. When that occurs, most people want to know wh

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-28 Thread Ferruh Yigit
On 9/28/2018 12:51 AM, Dan Gora wrote: > On Thu, Sep 27, 2018 at 8:44 PM, Ferruh Yigit wrote: >>> Well, yes the link_status (link up, link down) _is_ applied to the KNI >>> interface. When that occurs, most people want to know what the link >>> speed is that the link came up at. >> >> +1 to this,

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-28 Thread Igor Ryzhov
Hi Dan, Ferruh, Why do we need "struct rte_eth_link" as a parameter at all? Only link status is used in the function – let's use it only: rte_kni_update_link(struct rte_kni *kni, int link_status) /* 0 – down, 1 – up */ It will also solve your differences as we won't have any "redundant" informat

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-27 Thread Dan Gora
On Thu, Sep 27, 2018 at 8:44 PM, Ferruh Yigit wrote: >> Well, yes the link_status (link up, link down) _is_ applied to the KNI >> interface. When that occurs, most people want to know what the link >> speed is that the link came up at. > > +1 to this, people would like to know link speed of the i

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-27 Thread Ferruh Yigit
On 9/28/2018 12:05 AM, Dan Gora wrote: > On Thu, Sep 27, 2018 at 6:49 PM, Ferruh Yigit wrote: It would be useful if it writes the values of virtual interface, but this API prints user input. >>> I'm sorry, Ferruh, I really don't understand what you are referring to >>> here.

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-27 Thread Dan Gora
On Thu, Sep 27, 2018 at 6:49 PM, Ferruh Yigit wrote: >>> It would be useful if it writes the values of virtual interface, but this >>> API >>> prints user input. >>> >> I'm sorry, Ferruh, I really don't understand what you are referring to >> here. What virtual interface are you talking about? >

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-27 Thread Ferruh Yigit
On 9/27/2018 4:40 PM, Dan Gora wrote: > On Thu, Sep 27, 2018 at 8:35 AM Ferruh Yigit wrote: >> >> On 9/26/2018 7:56 PM, Dan Gora wrote: >>> On Wed, Sep 26, 2018 at 1:42 PM, Ferruh Yigit >>> wrote: > There is nothing to "reflect" to the kernel interface, nor to apply to > the kernel inter

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-27 Thread Dan Gora
On Thu, Sep 27, 2018 at 8:35 AM Ferruh Yigit wrote: > > On 9/26/2018 7:56 PM, Dan Gora wrote: > > On Wed, Sep 26, 2018 at 1:42 PM, Ferruh Yigit > > wrote: > >>> There is nothing to "reflect" to the kernel interface, nor to apply to > >>> the kernel interface. This is exactly how every other ker

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-27 Thread Ferruh Yigit
On 9/26/2018 7:56 PM, Dan Gora wrote: > On Wed, Sep 26, 2018 at 1:42 PM, Ferruh Yigit wrote: >>> There is nothing to "reflect" to the kernel interface, nor to apply to >>> the kernel interface. This is exactly how every other kernel driver >>> works on link status changes. There is no "netif_set

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-26 Thread Dan Gora
On Wed, Sep 26, 2018 at 1:42 PM, Ferruh Yigit wrote: >> There is nothing to "reflect" to the kernel interface, nor to apply to >> the kernel interface. This is exactly how every other kernel driver >> works on link status changes. There is no "netif_set_speed()' >> function. When a link status

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-26 Thread Ferruh Yigit
On 9/26/2018 3:55 PM, Dan Gora wrote: > On Wed, Sep 26, 2018 at 10:59 AM, Ferruh Yigit wrote: >> On 9/19/2018 8:55 PM, Dan Gora wrote: >>> Add a new API function to KNI, rte_kni_update_link() to allow DPDK >>> applications to update the link status for KNI network interfaces in >>> the linux kerne

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-26 Thread Dan Gora
On Wed, Sep 26, 2018 at 10:59 AM, Ferruh Yigit wrote: > On 9/19/2018 8:55 PM, Dan Gora wrote: >> Add a new API function to KNI, rte_kni_update_link() to allow DPDK >> applications to update the link status for KNI network interfaces in >> the linux kernel. >> >> Signed-off-by: Dan Gora > > <...>

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-26 Thread Ferruh Yigit
On 9/19/2018 8:55 PM, Dan Gora wrote: > Add a new API function to KNI, rte_kni_update_link() to allow DPDK > applications to update the link status for KNI network interfaces in > the linux kernel. > > Signed-off-by: Dan Gora <...> > +int __rte_experimental > +rte_kni_update_link(struct rte_kni

[dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-19 Thread Dan Gora
Add a new API function to KNI, rte_kni_update_link() to allow DPDK applications to update the link status for KNI network interfaces in the linux kernel. Signed-off-by: Dan Gora --- lib/librte_kni/rte_kni.c | 57 lib/librte_kni/rte_kni.h | 18 ++ lib/li