Re: [dpdk-dev] [PATCH v2 1/5] devargs: fix memory leak on parsing error

2021-03-18 Thread Thomas Monjalon
18/01/2021 16:16, Xueming Li: > --- a/lib/librte_eal/common/eal_common_devargs.c > +++ b/lib/librte_eal/common/eal_common_devargs.c > + if (ret != 0) { > + if (devargs->data && devargs->data != devstr) { Better to make comparison explicit: if (devargs->data != NULL > +

[dpdk-dev] [PATCH v2 1/5] devargs: fix memory leak on parsing error

2021-01-18 Thread Xueming Li
This patch fixes memory leak in parsing error handling. Fixes: 338327d731e6 ("devargs: add function to parse device layers") Cc: gaetan.ri...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Xueming Li --- lib/librte_eal/common/eal_common_devargs.c | 8 +++- 1 file changed, 7 insertions(+), 1 d