Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add tm support for shaper config in pkt mode

2020-04-21 Thread Dumitrescu, Cristian
Hi Nithin, ... > > You are missing the shaper_shared_(packet, byte)_mode supported for > non-leaf and leaf nodes in struct rte_tm_level_capabilities. > > > > The description of this nodes should be aligned with the description of e.g. > shaper_shared_n_max field: basically, we want to say that, w

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add tm support for shaper config in pkt mode

2020-04-21 Thread Nithin Dabilpuram
Hi Cristian, On Tue, Apr 21, 2020 at 09:30:55AM +, Dumitrescu, Cristian wrote: > Hi Nithin, > > > -Original Message- > > From: Nithin Dabilpuram > > Sent: Saturday, April 11, 2020 12:44 PM > > To: Dumitrescu, Cristian ; Thomas Monjalon > > ; Yigit, Ferruh ; Andrew > > Rybchenko > >

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add tm support for shaper config in pkt mode

2020-04-21 Thread Dumitrescu, Cristian
Hi Nithin, > -Original Message- > From: Nithin Dabilpuram > Sent: Saturday, April 11, 2020 12:44 PM > To: Dumitrescu, Cristian ; Thomas Monjalon > ; Yigit, Ferruh ; Andrew > Rybchenko > Cc: dev@dpdk.org; jer...@marvell.com; kka...@marvell.com; Nithin > Dabilpuram > Subject: [PATCH v2 1/

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add tm support for shaper config in pkt mode

2020-04-16 Thread Ferruh Yigit
On 4/11/2020 12:44 PM, Nithin Dabilpuram wrote: > From: Nithin Dabilpuram > > Some NIC hardware support shaper to work in packet mode i.e > shaping or ratelimiting traffic is in packets per second (PPS) as > opposed to default bytes per second (BPS). Hence this patch > adds support to configure s

[dpdk-dev] [PATCH v2 1/4] ethdev: add tm support for shaper config in pkt mode

2020-04-11 Thread Nithin Dabilpuram
From: Nithin Dabilpuram Some NIC hardware support shaper to work in packet mode i.e shaping or ratelimiting traffic is in packets per second (PPS) as opposed to default bytes per second (BPS). Hence this patch adds support to configure shared or private shaper in packet mode, provide rate in PPS