Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-30 Thread Thomas Monjalon
21/03/2018 15:27, Remy Horton: > +/* > + * Preferred Rx/Tx port parameters. > + */ > +struct rte_eth_dev_portconf { > + uint16_t burst_size; > + uint16_t ring_size; > + uint16_t nb_queues; > +}; Please add a doxygen comment for each field, thanks.

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-30 Thread Thomas Monjalon
30/03/2018 17:40, Thomas Monjalon: > I know that this patch is already applied, > but I have some comments below. > Please try to address them. > > 21/03/2018 15:27, Remy Horton: > > + /* If number of queues specified by application for both Rx and Tx is > > +* zero, use driver preferred val

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-30 Thread Thomas Monjalon
I know that this patch is already applied, but I have some comments below. Please try to address them. 21/03/2018 15:27, Remy Horton: > + /* If number of queues specified by application for both Rx and Tx is > + * zero, use driver preferred values. This cannot be done individually > +

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-28 Thread Shreyansh Jain
> -Original Message- > From: Remy Horton [mailto:remy.hor...@intel.com] > Sent: Wednesday, March 21, 2018 7:58 PM > To: dev@dpdk.org > Cc: John McNamara ; Wenzhuo Lu > ; Jingjing Wu ; Qi Zhang > ; Beilei Xing ; Shreyansh > Jain ; Thomas Monjalon > Subject: [PATCH v2 1/4] ethdev: add suppor

[dpdk-dev] [PATCH v2 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-21 Thread Remy Horton
The optimal values of several transmission & reception related parameters, such as burst sizes, descriptor ring sizes, and number of queues, varies between different network interface devices. This patch allows individual PMDs to specify preferred parameter values. Signed-off-by: Remy Horton ---