Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

2019-04-08 Thread Adrien Mazarguil
Hi Andrew, *Dekel* (I swear I'm not doing it on purpose, hopefully I won't make that stupid mistake again :) On Mon, Apr 08, 2019 at 04:53:54PM +0300, Andrew Rybchenko wrote: > On 4/8/19 4:36 PM, Dekel Peled wrote: > > Regarding Andrew's suggestion: "Shouldn't these action be > > RTE_FLOW_ACTION_

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

2019-04-08 Thread Andrew Rybchenko
On 4/8/19 4:36 PM, Dekel Peled wrote: Regarding Andrew's suggestion: "Shouldn't these action be RTE_FLOW_ACTION_TYPE_MOD_TCP_{ACK,SEQ} with singed 32-bit integer parameter (negative to decrement, positive to increment)?" I will leave the actions as is, the action names indicate the operation th

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

2019-04-08 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Adrien Mazarguil > Sent: Thursday, April 4, 2019 4:26 PM > To: Ori Kam > Cc: Dekel Peled ; wenzhuo...@intel.com; > jingjing...@intel.com; bernard.iremon...@intel.com; Yongseok Koh > ; Shahaf Shuler ; > dev@dpdk.org > Subject: Re: [PATCH v2 1/3] e

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

2019-04-05 Thread Andrew Rybchenko
On 4/4/19 4:25 PM, Adrien Mazarguil wrote: Hi Ori, (trimming message down a bit) On Thu, Apr 04, 2019 at 09:01:52AM +, Ori Kam wrote: Hi Adrien, PSB From: Adrien Mazarguil On Wed, Apr 03, 2019 at 10:49:09AM +, Dekel Peled wrote: Thanks, PSB. From: Adrien Mazarguil I sti

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

2019-04-04 Thread Adrien Mazarguil
Hi Ori, (trimming message down a bit) On Thu, Apr 04, 2019 at 09:01:52AM +, Ori Kam wrote: > Hi Adrien, > > PSB > > > From: Adrien Mazarguil > > On Wed, Apr 03, 2019 at 10:49:09AM +, Dekel Peled wrote: > > > Thanks, PSB. > > > > From: Adrien Mazarguil > > > > I still don't agree w

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

2019-04-04 Thread Ori Kam
Hi Adrien, PSB > -Original Message- > From: Adrien Mazarguil > Sent: Wednesday, April 3, 2019 3:49 PM > To: Dekel Peled > Cc: wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com; Yongseok Koh ; Shahaf > Shuler ; dev@dpdk.org; Ori Kam > > Subject: Re: [PATCH v2 1/

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

2019-04-03 Thread Adrien Mazarguil
On Wed, Apr 03, 2019 at 10:49:09AM +, Dekel Peled wrote: > Thanks, PSB. > > > -Original Message- > > From: Adrien Mazarguil > > Sent: Wednesday, April 3, 2019 12:15 PM > > To: Dekel Peled > > Cc: wenzhuo...@intel.com; jingjing...@intel.com; > > bernard.iremon...@intel.com; Yongseok K

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

2019-04-03 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Adrien Mazarguil > Sent: Wednesday, April 3, 2019 12:15 PM > To: Dekel Peled > Cc: wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com; Yongseok Koh ; > Shahaf Shuler ; dev@dpdk.org; Ori Kam > > Subject: Re: [PATCH v2 1/3]

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

2019-04-03 Thread Adrien Mazarguil
Hi Dekel, On Tue, Apr 02, 2019 at 06:13:19PM +0300, Dekel Peled wrote: > Add actions: > - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. > - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. > - INC_TCP_ACK - Increase acknowledgment number in the outermost TC

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

2019-04-02 Thread Ori Kam
el Peled > > Subject: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header > fields > > Add actions: > - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. > - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. > - INC_TC

[dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

2019-04-02 Thread Dekel Peled
Add actions: - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP header. - DEC_TCP_ACK - Decrease acknowledgment number in the