Re: [dpdk-dev] [PATCH v2 1/2] telemetry: support array values in data objects

2020-06-24 Thread Bruce Richardson
On Wed, Jun 24, 2020 at 02:48:23PM +0100, Ciara Power wrote: > Arrays and Dicts now support uint64_t, int and string > array values. Only one level of recursion supported. > > Signed-off-by: Ciara Power > A number of comments inline below. Once fixed you can include my ack on V3. Acked-by: Bru

Re: [dpdk-dev] [PATCH v2 1/2] telemetry: support array values in data objects

2020-06-24 Thread Bruce Richardson
On Wed, Jun 24, 2020 at 02:48:23PM +0100, Ciara Power wrote: > Arrays and Dicts now support uint64_t, int and string > array values. Only one level of recursion supported. > > Signed-off-by: Ciara Power > > --- Approach seems good to me, but I think you need more detail in the commit log for thi

[dpdk-dev] [PATCH v2 1/2] telemetry: support array values in data objects

2020-06-24 Thread Ciara Power
Arrays and Dicts now support uint64_t, int and string array values. Only one level of recursion supported. Signed-off-by: Ciara Power --- v2: - Added support for arrays to have container values. - Added support for int and string arrays within dict/array. - Added APIs for internal containe