Re: [dpdk-dev] [PATCH v2 1/2] net/pcap: physical interface MAC support

2018-04-19 Thread Ferruh Yigit
On 4/19/2018 6:16 AM, Kuusisaari, Juhamatti wrote: Why a build time config option for this? Can we make it a runtime devarg? >>> >>> Sure, we can make it a devarg. Or do we even need that? Are there a lot of >> test dependencies that would need to be fixed if we have it enabled by >> default?

Re: [dpdk-dev] [PATCH v2 1/2] net/pcap: physical interface MAC support

2018-04-18 Thread Kuusisaari, Juhamatti
> >> Why a build time config option for this? Can we make it a runtime devarg? > > > > Sure, we can make it a devarg. Or do we even need that? Are there a lot of > test dependencies that would need to be fixed if we have it enabled by > default? > > Not test dependencies but this may be overkill f

Re: [dpdk-dev] [PATCH v2 1/2] net/pcap: physical interface MAC support

2018-04-18 Thread Ferruh Yigit
On 4/18/2018 5:35 AM, Kuusisaari, Juhamatti wrote: > Hello Ferruh, > >> On 4/17/2018 1:53 PM, Juhamatti Kuusisaari wrote: >>> Support for PCAP MAC address using physical interface MAC. >>> Support for getting proper link status, speed and duplex. >>> >>> Signed-off-by: Juhamatti Kuusisaari >>> --

Re: [dpdk-dev] [PATCH v2 1/2] net/pcap: physical interface MAC support

2018-04-17 Thread Kuusisaari, Juhamatti
Hello Ferruh, > On 4/17/2018 1:53 PM, Juhamatti Kuusisaari wrote: > > Support for PCAP MAC address using physical interface MAC. > > Support for getting proper link status, speed and duplex. > > > > Signed-off-by: Juhamatti Kuusisaari > > --- > > config/common_base | 1 + > > drive

Re: [dpdk-dev] [PATCH v2 1/2] net/pcap: physical interface MAC support

2018-04-17 Thread Ferruh Yigit
On 4/17/2018 1:53 PM, Juhamatti Kuusisaari wrote: > Support for PCAP MAC address using physical interface MAC. > Support for getting proper link status, speed and duplex. > > Signed-off-by: Juhamatti Kuusisaari > --- > config/common_base | 1 + > drivers/net/pcap/rte_eth_pcap.c | 5

[dpdk-dev] [PATCH v2 1/2] net/pcap: physical interface MAC support

2018-04-17 Thread Juhamatti Kuusisaari
Support for PCAP MAC address using physical interface MAC. Support for getting proper link status, speed and duplex. Signed-off-by: Juhamatti Kuusisaari --- config/common_base | 1 + drivers/net/pcap/rte_eth_pcap.c | 52 - 2 files changed, 52