Re: [dpdk-dev] [PATCH v2 1/2] mk: fix cross build errors

2018-05-28 Thread Gavin Hu
Hi Bruce, Thanks for your helpful comment, see my inline comments. Best Regards, Gavin -Original Message- From: Bruce Richardson Sent: Monday, May 28, 2018 9:24 PM To: Gavin Hu Cc: dev@dpdk.org; sta...@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/2] mk: fix cross build errors On Mon

Re: [dpdk-dev] [PATCH v2 1/2] mk: fix cross build errors

2018-05-28 Thread Bruce Richardson
On Mon, May 28, 2018 at 02:53:47AM -0400, Gavin Hu wrote: > The "-Wimplicit-fallthrough=2" option was introduced into gcc 7.0, it was > enabled when the cross compiler gcc is greater than 7.0, but for the host > side buildtools/pmdinfogen, if the native is older than 7.0, it should not > be enabled

[dpdk-dev] [PATCH v2 1/2] mk: fix cross build errors

2018-05-27 Thread Gavin Hu
The "-Wimplicit-fallthrough=2" option was introduced into gcc 7.0, it was enabled when the cross compiler gcc is greater than 7.0, but for the host side buildtools/pmdinfogen, if the native is older than 7.0, it should not be enabled. The fix is to differentiate the host gcc Werror options from th