Re: [dpdk-dev] [PATCH v2 1/2] mk: allow use of environment var for make config

2017-06-07 Thread Bruce Richardson
On Wed, Jun 07, 2017 at 05:16:18PM +0530, Shreyansh Jain wrote: > On Wednesday 07 June 2017 03:58 PM, Hunt, David wrote: > > Hi Shreyansh, > > > > > > On 7/6/2017 10:36 AM, Shreyansh Jain wrote: > > > Hello David, > > > > > > On Wednesday 07 June 2017 02:09 PM, Hunt, David wrote: > > > > Shreyan

Re: [dpdk-dev] [PATCH v2 1/2] mk: allow use of environment var for make config

2017-06-07 Thread Shreyansh Jain
On Wednesday 07 June 2017 03:58 PM, Hunt, David wrote: Hi Shreyansh, On 7/6/2017 10:36 AM, Shreyansh Jain wrote: Hello David, On Wednesday 07 June 2017 02:09 PM, Hunt, David wrote: Shreyansh, I found an issue (or two) with this part of the patch, and have a proposed solution. 1. RTE

Re: [dpdk-dev] [PATCH v2 1/2] mk: allow use of environment var for make config

2017-06-07 Thread Hunt, David
Hi Shreyansh, On 7/6/2017 10:36 AM, Shreyansh Jain wrote: Hello David, On Wednesday 07 June 2017 02:09 PM, Hunt, David wrote: Shreyansh, I found an issue (or two) with this part of the patch, and have a proposed solution. 1. RTE_TARGET originally had a different meaning. It was used

Re: [dpdk-dev] [PATCH v2 1/2] mk: allow use of environment var for make config

2017-06-07 Thread Shreyansh Jain
Hello David, On Wednesday 07 June 2017 02:09 PM, Hunt, David wrote: Shreyansh, I found an issue (or two) with this part of the patch, and have a proposed solution. 1. RTE_TARGET originally had a different meaning. It was used for making examples, specifying the target directory of wher

Re: [dpdk-dev] [PATCH v2 1/2] mk: allow use of environment var for make config

2017-06-07 Thread Hunt, David
Shreyansh, I found an issue (or two) with this part of the patch, and have a proposed solution. 1. RTE_TARGET originally had a different meaning. It was used for making examples, specifying the target directory of where the SDK was built. It's not good to re-purpose this for something el

[dpdk-dev] [PATCH v2 1/2] mk: allow use of environment var for make config

2017-05-26 Thread David Hunt
Users can now set RTE_TARGET in their environment and use 'make config' without T=template. If RTE_TARGET is set in the user's environment, and if T= is not used, 'make config' will use $RTE_TARGET. Signed-off-by: David Hunt --- mk/rte.sdkroot.mk | 2 ++ 1 file changed, 2 insertions(+) diff --