[dpdk-dev] [PATCH v2 1/2] drivers/i40e: fix X722 macro absence result in compile

2016-10-19 Thread Guo, Jia
hi,yigit Because of remove "#ifdef x722" will related with some prior patch and need related folks to make agreement on that, so we need to make a discuss later to get a conclusion. we definitely confidence that we will get the better balance base on the code maintenance effective. so just

[dpdk-dev] [PATCH v2 1/2] drivers/i40e: fix X722 macro absence result in compile

2016-10-18 Thread Ferruh Yigit
On 10/17/2016 10:54 AM, Ananyev, Konstantin wrote: > Hi Jeff, > >> >> hi, Konstantin >> Thanks your constructive suggestion. I don't think your question is >> silly and we also think about the code style simply and effective, but >> may be i would interpret the reason why we do that. >> >> 1) Sure

[dpdk-dev] [PATCH v2 1/2] drivers/i40e: fix X722 macro absence result in compile

2016-10-17 Thread Guo, Jia
ntin wrote: > Hi Jeff, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jeff Guo >> Sent: Sunday, October 16, 2016 2:40 AM >> To: Zhang, Helin ; Wu, Jingjing > intel.com> >> Cc: dev at dpdk.org; Guo, Jia >> Subje

[dpdk-dev] [PATCH v2 1/2] drivers/i40e: fix X722 macro absence result in compile

2016-10-17 Thread Chilikin, Andrey
and hard to maintain. > Konstantin > > > > > > > > > On 10/16/2016 9:31 PM, Ananyev, Konstantin wrote: > > > Hi Jeff, > > > > > >> -----Original Message----- > > >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jeff Gu

[dpdk-dev] [PATCH v2 1/2] drivers/i40e: fix X722 macro absence result in compile

2016-10-17 Thread Ananyev, Konstantin
>> Sent: Sunday, October 16, 2016 2:40 AM > >> To: Zhang, Helin ; Wu, Jingjing >> intel.com> > >> Cc: dev at dpdk.org; Guo, Jia > >> Subject: [dpdk-dev] [PATCH v2 1/2] drivers/i40e: fix X722 macro absence > >> result in compile > >> &

[dpdk-dev] [PATCH v2 1/2] drivers/i40e: fix X722 macro absence result in compile

2016-10-16 Thread Ananyev, Konstantin
Hi Jeff, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jeff Guo > Sent: Sunday, October 16, 2016 2:40 AM > To: Zhang, Helin ; Wu, Jingjing intel.com> > Cc: dev at dpdk.org; Guo, Jia > Subject: [dpdk-dev] [PATCH v2 1/2] drivers

[dpdk-dev] [PATCH v2 1/2] drivers/i40e: fix X722 macro absence result in compile

2016-10-15 Thread Jeff Guo
Since some register only be supported by X722 but may not be supported by other NICs, so add X722 macro to distinguish that to avoid compile error when the X722 macro is undefined. Fixes: d0a349409bd7 (?i40e: support AQ based RSS config?) Fixes: 001a1c0f98f4 ("ethdev: get registers width") Fixes:

[dpdk-dev] [PATCH v2 1/2] drivers/i40e: fix X722 macro absence result in compile

2016-10-15 Thread Jeff Guo
Since some register only be supported by X722 but may not be supported by other NICs, so add X722 macro to distinguish that to avoid compile error when the X722 macro is undefined. Fixes: d0a349409bd7 (?i40e: support AQ based RSS config?) Fixes: 001a1c0f98f4 ("ethdev: get registers width") Fixes: