Re: [dpdk-dev] [PATCH v2 07/13] net/avp: fix errors in exported headers

2017-04-25 Thread Legacy, Allain
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, April 25, 2017 10:49 AM <...> > > Thank you. > > Can I add your acked-by line directly assuming all the above is done as > described? Yes.

Re: [dpdk-dev] [PATCH v2 07/13] net/avp: fix errors in exported headers

2017-04-25 Thread Adrien Mazarguil
On Tue, Apr 25, 2017 at 01:00:46PM +, Legacy, Allain wrote: > > -Original Message- > > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > > Sent: Tuesday, April 25, 2017 8:50 AM > <...> > > > 2) RTE_STD_C11 needs to be included in the #ifdef __KERNEL__. > > > > Missed that on

Re: [dpdk-dev] [PATCH v2 07/13] net/avp: fix errors in exported headers

2017-04-25 Thread Legacy, Allain
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, April 25, 2017 8:50 AM <...> > > 2) RTE_STD_C11 needs to be included in the #ifdef __KERNEL__. > > Missed that one, however I suggest either: > > #ifndef __KERNEL__ around RTE_STD_C11 > >

Re: [dpdk-dev] [PATCH v2 07/13] net/avp: fix errors in exported headers

2017-04-25 Thread Adrien Mazarguil
On Tue, Apr 25, 2017 at 12:31:56PM +, Legacy, Allain wrote: > > -Original Message- > > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > > Sent: Tuesday, April 25, 2017 4:30 AM > <...> > > > > +#include > > #ifdef __KERNEL__ > > #include > > +#else > > +#include > > +#i

Re: [dpdk-dev] [PATCH v2 07/13] net/avp: fix errors in exported headers

2017-04-25 Thread Legacy, Allain
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, April 25, 2017 4:30 AM <...> > > +#include > #ifdef __KERNEL__ > #include > +#else > +#include > +#include > +#include > +#include > +#endif I compiled this in our environment and fo

[dpdk-dev] [PATCH v2 07/13] net/avp: fix errors in exported headers

2017-04-25 Thread Adrien Mazarguil
This commit addresses several errors related to missing includes such as: In file included from /tmp/check-includes.sh.15315.c:1:0: build/include/rte_avp_fifo.h:77:22: error: 'struct rte_avp_fifo' declared inside parameter list [-Werror] [...] build/include/rte_avp_fifo.h: In function 'avp