Re: [dpdk-dev] [PATCH v2 02/17] vhost: fix return code of messages requiring replies

2018-10-03 Thread Ilya Maximets
On 03.10.2018 17:49, Maxime Coquelin wrote: > > > On 10/03/2018 03:26 PM, Ilya Maximets wrote: >> On 02.10.2018 12:36, Maxime Coquelin wrote: >>> VHOST_USER_GET_PROTOCOL_FEATURES, VHOST_USER_GET_VRING_BASE >>> and VHOST_USER_SET_LOG_BASE require replies, so their handlers >>> should return VH_RES

Re: [dpdk-dev] [PATCH v2 02/17] vhost: fix return code of messages requiring replies

2018-10-03 Thread Maxime Coquelin
On 10/03/2018 03:26 PM, Ilya Maximets wrote: On 02.10.2018 12:36, Maxime Coquelin wrote: VHOST_USER_GET_PROTOCOL_FEATURES, VHOST_USER_GET_VRING_BASE and VHOST_USER_SET_LOG_BASE require replies, so their handlers should return VH_RESULT_REPLY, not VH_RESULT_OK. Fixes: 2cfbbb86c62a ("vhost: un

Re: [dpdk-dev] [PATCH v2 02/17] vhost: fix return code of messages requiring replies

2018-10-03 Thread Ilya Maximets
On 02.10.2018 12:36, Maxime Coquelin wrote: > VHOST_USER_GET_PROTOCOL_FEATURES, VHOST_USER_GET_VRING_BASE > and VHOST_USER_SET_LOG_BASE require replies, so their handlers > should return VH_RESULT_REPLY, not VH_RESULT_OK. > > Fixes: 2cfbbb86c62a ("vhost: unify message handling function signature")

[dpdk-dev] [PATCH v2 02/17] vhost: fix return code of messages requiring replies

2018-10-02 Thread Maxime Coquelin
VHOST_USER_GET_PROTOCOL_FEATURES, VHOST_USER_GET_VRING_BASE and VHOST_USER_SET_LOG_BASE require replies, so their handlers should return VH_RESULT_REPLY, not VH_RESULT_OK. Fixes: 2cfbbb86c62a ("vhost: unify message handling function signature") Signed-off-by: Maxime Coquelin --- lib/librte_vhos