Re: [dpdk-dev] [PATCH v2 02/10] telemetry: add initial connection socket

2018-10-03 Thread Mattias Rönnblom
On 2018-10-03 21:36, Thomas Monjalon wrote: 03/10/2018 20:40, Mattias Rönnblom: On 2018-10-03 19:36, Kevin Laatz wrote: +#define DEFAULT_DPDK_PATH "/var/run/.rte_telemetry" + FHS 3.0 recommends "/run" over "/var/run". Maybe a more descriptive macro name would be in order, too. Kevin, you sh

Re: [dpdk-dev] [PATCH v2 02/10] telemetry: add initial connection socket

2018-10-03 Thread Thomas Monjalon
03/10/2018 20:40, Mattias Rönnblom: > On 2018-10-03 19:36, Kevin Laatz wrote: > > +#define DEFAULT_DPDK_PATH "/var/run/.rte_telemetry" > > + > > FHS 3.0 recommends "/run" over "/var/run". Maybe a more descriptive > macro name would be in order, too. Kevin, you should use eal_get_runtime_dir(). Y

Re: [dpdk-dev] [PATCH v2 02/10] telemetry: add initial connection socket

2018-10-03 Thread Mattias Rönnblom
On 2018-10-03 19:36, Kevin Laatz wrote: From: Ciara Power This patch adds the telemetry UNIX socket. It is used to allow connections from external clients. On the initial connection from a client, ethdev stats are registered in the metrics library, to allow for their retrieval at a later stage

[dpdk-dev] [PATCH v2 02/10] telemetry: add initial connection socket

2018-10-03 Thread Kevin Laatz
From: Ciara Power This patch adds the telemetry UNIX socket. It is used to allow connections from external clients. On the initial connection from a client, ethdev stats are registered in the metrics library, to allow for their retrieval at a later stage. Signed-off-by: Ciara Power Signed-off-