Re: [dpdk-dev] [PATCH v2 01/17] vhost: fix messages error checks

2018-10-03 Thread Ilya Maximets
On 03.10.2018 17:39, Maxime Coquelin wrote: > > > On 10/03/2018 11:07 AM, Ilya Maximets wrote: >> On 03.10.2018 11:32, Ilya Maximets wrote: >>> On 03.10.2018 11:02, Maxime Coquelin wrote: On 10/03/2018 09:57 AM, Ilya Maximets wrote: > On 03.10.2018 10:50, Maxime Coquelin wrote:

Re: [dpdk-dev] [PATCH v2 01/17] vhost: fix messages error checks

2018-10-03 Thread Maxime Coquelin
On 10/03/2018 11:07 AM, Ilya Maximets wrote: On 03.10.2018 11:32, Ilya Maximets wrote: On 03.10.2018 11:02, Maxime Coquelin wrote: On 10/03/2018 09:57 AM, Ilya Maximets wrote: On 03.10.2018 10:50, Maxime Coquelin wrote: On 10/02/2018 04:15 PM, Ilya Maximets wrote: On 02.10.2018 12:36,

Re: [dpdk-dev] [PATCH v2 01/17] vhost: fix messages error checks

2018-10-03 Thread Ilya Maximets
On 03.10.2018 11:32, Ilya Maximets wrote: > On 03.10.2018 11:02, Maxime Coquelin wrote: >> >> >> On 10/03/2018 09:57 AM, Ilya Maximets wrote: >>> On 03.10.2018 10:50, Maxime Coquelin wrote: On 10/02/2018 04:15 PM, Ilya Maximets wrote: > On 02.10.2018 12:36, Maxime Coquelin wrote:

Re: [dpdk-dev] [PATCH v2 01/17] vhost: fix messages error checks

2018-10-03 Thread Ilya Maximets
On 03.10.2018 11:02, Maxime Coquelin wrote: > > > On 10/03/2018 09:57 AM, Ilya Maximets wrote: >> On 03.10.2018 10:50, Maxime Coquelin wrote: >>> >>> >>> On 10/02/2018 04:15 PM, Ilya Maximets wrote: On 02.10.2018 12:36, Maxime Coquelin wrote: > Return of message handling has now changed

Re: [dpdk-dev] [PATCH v2 01/17] vhost: fix messages error checks

2018-10-03 Thread Maxime Coquelin
On 10/03/2018 09:57 AM, Ilya Maximets wrote: On 03.10.2018 10:50, Maxime Coquelin wrote: On 10/02/2018 04:15 PM, Ilya Maximets wrote: On 02.10.2018 12:36, Maxime Coquelin wrote: Return of message handling has now changed to an enum that can take non-negative value that is not zero in case

Re: [dpdk-dev] [PATCH v2 01/17] vhost: fix messages error checks

2018-10-03 Thread Ilya Maximets
On 03.10.2018 10:50, Maxime Coquelin wrote: > > > On 10/02/2018 04:15 PM, Ilya Maximets wrote: >> On 02.10.2018 12:36, Maxime Coquelin wrote: >>> Return of message handling has now changed to an enum that can >>> take non-negative value that is not zero in case a reply is >>> needed. But the code

Re: [dpdk-dev] [PATCH v2 01/17] vhost: fix messages error checks

2018-10-03 Thread Maxime Coquelin
On 10/02/2018 04:15 PM, Ilya Maximets wrote: On 02.10.2018 12:36, Maxime Coquelin wrote: Return of message handling has now changed to an enum that can take non-negative value that is not zero in case a reply is needed. But the code checking the variable afterwards has not been updated, leadi

Re: [dpdk-dev] [PATCH v2 01/17] vhost: fix messages error checks

2018-10-02 Thread Ilya Maximets
On 02.10.2018 12:36, Maxime Coquelin wrote: > Return of message handling has now changed to an enum that can > take non-negative value that is not zero in case a reply is > needed. But the code checking the variable afterwards has not > been updated, leading to success messages handling being > tre

[dpdk-dev] [PATCH v2 01/17] vhost: fix messages error checks

2018-10-02 Thread Maxime Coquelin
Return of message handling has now changed to an enum that can take non-negative value that is not zero in case a reply is needed. But the code checking the variable afterwards has not been updated, leading to success messages handling being treated as errors. Fixes: 4e601952cae6 ("vhost: message