Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free

2019-07-08 Thread Thomas Monjalon
08/07/2019 18:51, Wang, Yipeng1: >From: Thomas Monjalon [mailto:tho...@monjalon.net] > >02/07/2019 23:16, Honnappa Nagarahalli: > >> v2 > >> - Dropped moving the tbl_chng_cnt to the beginning of the cache line > >>commit > >> - Changed the commit log for patch 1 to indicate that it improves >

Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free

2019-07-08 Thread Wang, Yipeng1
>ruifeng.w...@arm.com; n...@arm.com >Subject: Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for >lock-free > >02/07/2019 23:16, Honnappa Nagarahalli: >> v2 >> - Dropped moving the tbl_chng_cnt to the beginning of the cache line >>commit >> -

Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free

2019-07-04 Thread Thomas Monjalon
05/07/2019 08:14, Honnappa Nagarahalli: > > 02/07/2019 23:16, Honnappa Nagarahalli: > > > v2 > > > - Dropped moving the tbl_chng_cnt to the beginning of the cache line > > >commit > > > - Changed the commit log for patch 1 to indicate that it improves > > >performance (Yipeng) > > > - Ch

Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free

2019-07-04 Thread Honnappa Nagarahalli
> 02/07/2019 23:16, Honnappa Nagarahalli: > > v2 > > - Dropped moving the tbl_chng_cnt to the beginning of the cache line > >commit > > - Changed the commit log for patch 1 to indicate that it improves > >performance (Yipeng) > > - Changed the comment in the search_one_bucket_lf function

Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free

2019-07-04 Thread Honnappa Nagarahalli
> [Snip] > > > The first patch in this series moves the signature comparison before > > the load- acquire of the key_index. This does not result in any issues > > because of the full key comparison which is done after the load-acquire of > the key_index. > > Performance improvements: > > Lookup Hi

Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free

2019-07-04 Thread Thomas Monjalon
02/07/2019 23:16, Honnappa Nagarahalli: > v2 > - Dropped moving the tbl_chng_cnt to the beginning of the cache line >commit > - Changed the commit log for patch 1 to indicate that it improves >performance (Yipeng) > - Changed the comment in the search_one_bucket_lf function (Yipeng) > -

Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free

2019-07-04 Thread Jerin Jacob Kollanukkaran
..@arm.com; ruifeng.w...@arm.com; dev@dpdk.org; > n...@arm.com > Subject: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock- > free [Snip] > The first patch in this series moves the signature comparison before the load- > acquire of the key_index. This does not result

[dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free

2019-07-02 Thread Honnappa Nagarahalli
While using the rte_hash library, there are 2 sets of stores that happen. 1) The application writes its data to memory (whose address is provided in rte_hash_add_key_with_hash_data API (or NULL)) 2) The rte_hash library writes to its own internal data structures; key store entry and the hash table