Re: [dpdk-dev] [PATCH v2] service: don't walk out of bounds when checking services

2020-02-14 Thread Kevin Traynor
On 07/02/2020 14:27, Aaron Conole wrote: > Kevin Traynor writes: > >> On 20/12/2019 14:43, David Marchand wrote: >>> On Wed, Dec 4, 2019 at 9:34 AM David Marchand >>> wrote: On Wed, Dec 4, 2019 at 9:33 AM David Marchand wrote: > > On Tue, Dec 3, 2019 at 10:15 PM Aaron C

Re: [dpdk-dev] [PATCH v2] service: don't walk out of bounds when checking services

2020-02-07 Thread Aaron Conole
Kevin Traynor writes: > On 20/12/2019 14:43, David Marchand wrote: >> On Wed, Dec 4, 2019 at 9:34 AM David Marchand >> wrote: >>> >>> On Wed, Dec 4, 2019 at 9:33 AM David Marchand >>> wrote: On Tue, Dec 3, 2019 at 10:15 PM Aaron Conole wrote: > > The service_valid call is u

Re: [dpdk-dev] [PATCH v2] service: don't walk out of bounds when checking services

2020-02-07 Thread Kevin Traynor
On 20/12/2019 14:43, David Marchand wrote: > On Wed, Dec 4, 2019 at 9:34 AM David Marchand > wrote: >> >> On Wed, Dec 4, 2019 at 9:33 AM David Marchand >> wrote: >>> >>> On Tue, Dec 3, 2019 at 10:15 PM Aaron Conole wrote: The service_valid call is used without properly bounds checkin

Re: [dpdk-dev] [PATCH v2] service: don't walk out of bounds when checking services

2019-12-20 Thread David Marchand
On Wed, Dec 4, 2019 at 9:34 AM David Marchand wrote: > > On Wed, Dec 4, 2019 at 9:33 AM David Marchand > wrote: > > > > On Tue, Dec 3, 2019 at 10:15 PM Aaron Conole wrote: > > > > > > The service_valid call is used without properly bounds checking the > > > input parameter. Almost all instance

Re: [dpdk-dev] [PATCH v2] service: don't walk out of bounds when checking services

2019-12-04 Thread David Marchand
On Wed, Dec 4, 2019 at 9:33 AM David Marchand wrote: > > On Tue, Dec 3, 2019 at 10:15 PM Aaron Conole wrote: > > > > The service_valid call is used without properly bounds checking the > > input parameter. Almost all instances of the service_valid call are > > inside a for() loop that prevents e

Re: [dpdk-dev] [PATCH v2] service: don't walk out of bounds when checking services

2019-12-04 Thread David Marchand
On Tue, Dec 3, 2019 at 10:15 PM Aaron Conole wrote: > > The service_valid call is used without properly bounds checking the > input parameter. Almost all instances of the service_valid call are > inside a for() loop that prevents excessive walks, but some of the > public APIs don't bounds check a

[dpdk-dev] [PATCH v2] service: don't walk out of bounds when checking services

2019-12-03 Thread Aaron Conole
The service_valid call is used without properly bounds checking the input parameter. Almost all instances of the service_valid call are inside a for() loop that prevents excessive walks, but some of the public APIs don't bounds check and will pass invalid arguments. Prevent this by using SERVICE_