12/10/2020 22:58, Harris, James R:
>
> On 10/7/20, 8:06 AM, "Thomas Monjalon" wrote:
>
> Hi Jim,
>
> Sorry I see nobody reviewed your patch.
>
> Jim Harris wrote:
> > + memcpy(&dev2->id, &dev->id, sizeof(dev2->id));
> [...]
> > + memcmp(&dev2->id, &dev->id, sizeof(dev
On 10/7/20, 8:06 AM, "Thomas Monjalon" wrote:
Hi Jim,
Sorry I see nobody reviewed your patch.
Jim Harris wrote:
> + memcpy(&dev2->id, &dev->id, sizeof(dev2->id));
[...]
> + memcmp(&dev2->id, &dev->id, sizeof(dev2->id)))
Why using memcpy and memcmp instead of sim
Hi Jim,
Sorry I see nobody reviewed your patch.
Jim Harris wrote:
> + memcpy(&dev2->id, &dev->id, sizeof(dev2->id));
[...]
> + memcmp(&dev2->id, &dev->id, sizeof(dev2->id)))
Why using memcpy and memcmp instead of simple assignment and comparison?
When a device is inserted into an existing BDF slot
that has not been probed, we must overwrite the old
PCI ID with the ID of the new function. Otherwise
we may not probe the function with the correct driver,
if at all.
Signed-off-by: Jim Harris
---
drivers/bus/pci/linux/pci.c | 4 +++-
1 file c
4 matches
Mail list logo
