Re: [dpdk-dev] [PATCH v2] net/virtio: fix advertised Rx offload capabilities

2017-01-17 Thread Olivier Matz
On Tue, 17 Jan 2017 19:08:38 +0800, Yuanhan Liu wrote: > On Tue, Jan 17, 2017 at 11:35:53AM +0100, Olivier Matz wrote: > > > + host_features = hw->vtpci_ops->get_features(hw); > > Note that hw->vtpci_ops doesn't exist any more, due to fixing the > virtio multiple process bugs. I changed it

Re: [dpdk-dev] [PATCH v2] net/virtio: fix advertised Rx offload capabilities

2017-01-17 Thread Yuanhan Liu
On Tue, Jan 17, 2017 at 11:35:53AM +0100, Olivier Matz wrote: > + host_features = hw->vtpci_ops->get_features(hw); Note that hw->vtpci_ops doesn't exist any more, due to fixing the virtio multiple process bugs. I changed it to: host_features = VTPCI_OPS(hw)->get_features(hw); And a

[dpdk-dev] [PATCH v2] net/virtio: fix advertised Rx offload capabilities

2017-01-17 Thread Olivier Matz
When the virtio PMD is used on top of a vhost that does not support offloads, Rx offload capabilities are still advertised by virtio_dev_info_get(). But if an application tries to start the PMD with Rx offloads enabled (rxmode.hw_ip_checksum = 1), the initialization of the device will fail with -EN