Re: [dpdk-dev] [PATCH v2] net/mlx5: change device reference for secondary process

2018-05-06 Thread Yongseok Koh
> On May 5, 2018, at 11:25 PM, Shahaf Shuler wrote: > > Hi Koh, > > See some small comments. > > Thursday, May 3, 2018 2:11 AM, Yongseok Koh: >> Subject: [dpdk-dev] [PATCH v2] net/mlx5: change device reference for >> secondary process >> >> rte_et

Re: [dpdk-dev] [PATCH v2] net/mlx5: change device reference for secondary process

2018-05-05 Thread Shahaf Shuler
Hi Koh, See some small comments. Thursday, May 3, 2018 2:11 AM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v2] net/mlx5: change device reference for > secondary process > > rte_eth_devices[] is not shared between primary and secondary process, > but a static array to each proce

[dpdk-dev] [PATCH v2] net/mlx5: change device reference for secondary process

2018-05-02 Thread Yongseok Koh
rte_eth_devices[] is not shared between primary and secondary process, but a static array to each process. The reverse pointer of device (priv->dev) is invalid. Instead, priv has the pointer to shared data of the device, struct rte_eth_dev_data *dev_data; Two macros are added, #define port_id(