Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

2018-08-31 Thread Luca Boccassi
On Wed, 2018-08-29 at 13:59 +0200, Nélio Laranjeiro wrote: > On Wed, Aug 29, 2018 at 11:00:54AM +0100, Luca Boccassi wrote: > > On Tue, 2018-08-28 at 16:45 +0100, Bruce Richardson wrote: > > > Thanks for this, comments inline below. > > > > > > /Bruce > > > > > > On Mon, Aug 27, 2018 at 02:42:25P

Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

2018-08-29 Thread Nélio Laranjeiro
On Wed, Aug 29, 2018 at 11:01:15AM +0100, Bruce Richardson wrote: > On Wed, Aug 29, 2018 at 11:34:10AM +0200, Nélio Laranjeiro wrote: > > Hi Bruce, > > > > Thanks for your comments I have address almost all of them in the v3 by > > doing what you suggest, I still have some comments, please see bel

Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

2018-08-29 Thread Luca Boccassi
On Wed, 2018-08-29 at 13:59 +0200, Nélio Laranjeiro wrote: > On Wed, Aug 29, 2018 at 11:00:54AM +0100, Luca Boccassi wrote: > > On Tue, 2018-08-28 at 16:45 +0100, Bruce Richardson wrote: > > > Thanks for this, comments inline below. > > > > > > /Bruce > > > > > > On Mon, Aug 27, 2018 at 02:42:25P

Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

2018-08-29 Thread Nélio Laranjeiro
On Wed, Aug 29, 2018 at 11:00:54AM +0100, Luca Boccassi wrote: > On Tue, 2018-08-28 at 16:45 +0100, Bruce Richardson wrote: > > Thanks for this, comments inline below. > > > > /Bruce > > > > On Mon, Aug 27, 2018 at 02:42:25PM +0200, Nelio Laranjeiro wrote: > > > Mellanox drivers remains un-compil

Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

2018-08-29 Thread Bruce Richardson
On Wed, Aug 29, 2018 at 11:34:10AM +0200, Nélio Laranjeiro wrote: > Hi Bruce, > > Thanks for your comments I have address almost all of them in the v3 by > doing what you suggest, I still have some comments, please see below, > Thanks. > On Tue, Aug 28, 2018 at 04:45:00PM +0100, Bruce Richardso

Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

2018-08-29 Thread Luca Boccassi
On Tue, 2018-08-28 at 16:45 +0100, Bruce Richardson wrote: > Thanks for this, comments inline below. > > /Bruce > > On Mon, Aug 27, 2018 at 02:42:25PM +0200, Nelio Laranjeiro wrote: > > Mellanox drivers remains un-compiled by default due to third party > > libraries dependencies.  They can be ena

Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

2018-08-29 Thread Nélio Laranjeiro
Hi Bruce, Thanks for your comments I have address almost all of them in the v3 by doing what you suggest, I still have some comments, please see below, On Tue, Aug 28, 2018 at 04:45:00PM +0100, Bruce Richardson wrote: > Thanks for this, comments inline below. > > /Bruce > > On Mon, Aug 27, 2018

Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

2018-08-28 Thread Bruce Richardson
Thanks for this, comments inline below. /Bruce On Mon, Aug 27, 2018 at 02:42:25PM +0200, Nelio Laranjeiro wrote: > Mellanox drivers remains un-compiled by default due to third party > libraries dependencies. They can be enabled through: > - enable_driver_mlx{4,5}=true or > - enable_driver_mlx{4,

[dpdk-dev] [PATCH v2] net/mlx: add meson build support

2018-08-27 Thread Nelio Laranjeiro
Mellanox drivers remains un-compiled by default due to third party libraries dependencies. They can be enabled through: - enable_driver_mlx{4,5}=true or - enable_driver_mlx{4,5}_glue=true depending on the needs. To avoid modifying the whole sources and keep the compatibility with current build sy