Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-17 Thread Zhao1, Wei
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, March 15, 2019 9:00 PM > To: Zhao1, Wei ; Zhang, Qi Z ; > David Harton (dharton) > Cc: Lu, Wenzhuo ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf > > Hi Wei, > > > > > > > > >

Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-15 Thread Ananyev, Konstantin
Hi Wei, > > > > > > > > > > > > > > Hi Qi, > > > > > > > > > > > > > > This patch was rejected with no feedback. > > > > > > > > > > > > > > Can you share why? > > > > > > > > > > > > Because as Zhao Wei explained in v1 thread, in > > > > > > ixgbe_vlan_offload_config , ETH_VLAN_FILTER_MASK and >

Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-15 Thread Zhao1, Wei
Hi , Konstantin > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, March 15, 2019 5:24 PM > To: Zhao1, Wei ; Zhang, Qi Z ; > David Harton (dharton) > Cc: Lu, Wenzhuo ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf > > > > > > Hi,q

Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-15 Thread Ananyev, Konstantin
> > Hi,qi > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Friday, March 15, 2019 9:20 AM > > To: David Harton (dharton) > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > ; dev@dpdk.org; Zhao1, Wei > > > > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf >

Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-15 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Friday, March 15, 2019 1:28 PM > To: Zhang, Qi Z ; David Harton (dharton) > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf > > Hi,qi > > > -Origina

Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-14 Thread Zhao1, Wei
Hi,qi > -Original Message- > From: Zhang, Qi Z > Sent: Friday, March 15, 2019 9:20 AM > To: David Harton (dharton) > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; dev@dpdk.org; Zhao1, Wei > > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf > > > > > -Original

Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-14 Thread Zhao1, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, March 15, 2019 9:20 AM > To: David Harton (dharton) > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; dev@dpdk.org; Zhao1, Wei > > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf > > > > > -Original Mes

Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-14 Thread Zhang, Qi Z
> -Original Message- > From: David Harton (dharton) [mailto:dhar...@cisco.com] > Sent: Thursday, March 14, 2019 11:51 PM > To: Zhang, Qi Z > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf > > Hi Qi, >

Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-14 Thread David Harton (dharton)
Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, March 14, 2019 11:14 AM > To: David Harton (dharton) > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf > > > > > -Original Message--

Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-14 Thread Zhang, Qi Z
> -Original Message- > From: David Harton (dharton) [mailto:dhar...@cisco.com] > Sent: Thursday, March 14, 2019 9:38 PM > To: David Harton (dharton) ; Zhang, Qi Z > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend f

Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-14 Thread David Harton (dharton)
Hi Qi, This patch was rejected with no feedback. Can you share why? Without this patch users are not able to call the rte_eth_dev_vlan_filter() API for ixgbevf based ports because VLAN_FILTER cannot be enabled when calling rte_eth_dev_configure(). Or, am I missing something? Thanks, Dave >

[dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-08 Thread David Harton
ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation. Restoring the capbility to enable these offloads at configuration time. Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") Signed-off-by: David Harton --- v2: removed unused