Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-25 Thread Hyong Youb Kim
[...] > > > I see it can work if an application always wants this config option to > > > have > > > *same* value. So it can set this in eal_init() always. > > > > > > This requires "driver=xxx,key=value" kind of support in devargs. > > > > > > > > > John, Hyong, > > > > > > I guess some lev

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-25 Thread Gaëtan Rivet
On Mon, Mar 25, 2019 at 02:26:27PM +0100, Gaëtan Rivet wrote: > On Mon, Mar 25, 2019 at 11:49:20AM +, Ferruh Yigit wrote: > > On 3/20/2019 11:46 AM, Thomas Monjalon wrote: > > > 20/03/2019 11:45, Ferruh Yigit: > > >> On 3/19/2019 8:30 PM, Thomas Monjalon wrote: > > >>> 19/03/2019 19:00, Ferruh

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-25 Thread Gaëtan Rivet
On Mon, Mar 25, 2019 at 11:49:20AM +, Ferruh Yigit wrote: > On 3/20/2019 11:46 AM, Thomas Monjalon wrote: > > 20/03/2019 11:45, Ferruh Yigit: > >> On 3/19/2019 8:30 PM, Thomas Monjalon wrote: > >>> 19/03/2019 19:00, Ferruh Yigit: > On 3/19/2019 5:36 PM, Thomas Monjalon wrote: > > 19/03

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-25 Thread Ferruh Yigit
On 3/20/2019 11:46 AM, Thomas Monjalon wrote: > 20/03/2019 11:45, Ferruh Yigit: >> On 3/19/2019 8:30 PM, Thomas Monjalon wrote: >>> 19/03/2019 19:00, Ferruh Yigit: On 3/19/2019 5:36 PM, Thomas Monjalon wrote: > 19/03/2019 18:29, Ferruh Yigit: >> On 3/14/2019 10:04 PM, Thomas Monjalon w

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-20 Thread Thomas Monjalon
20/03/2019 11:45, Ferruh Yigit: > On 3/19/2019 8:30 PM, Thomas Monjalon wrote: > > 19/03/2019 19:00, Ferruh Yigit: > >> On 3/19/2019 5:36 PM, Thomas Monjalon wrote: > >>> 19/03/2019 18:29, Ferruh Yigit: > On 3/14/2019 10:04 PM, Thomas Monjalon wrote: > > 14/03/2019 03:58, Hyong Youb Kim: >

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-20 Thread Ferruh Yigit
On 3/19/2019 8:30 PM, Thomas Monjalon wrote: > 19/03/2019 19:00, Ferruh Yigit: >> On 3/19/2019 5:36 PM, Thomas Monjalon wrote: >>> 19/03/2019 18:29, Ferruh Yigit: On 3/14/2019 10:04 PM, Thomas Monjalon wrote: > 14/03/2019 03:58, Hyong Youb Kim: >> On Wed, Mar 13, 2019 at 10:29:53PM +01

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-19 Thread Thomas Monjalon
19/03/2019 19:00, Ferruh Yigit: > On 3/19/2019 5:36 PM, Thomas Monjalon wrote: > > 19/03/2019 18:29, Ferruh Yigit: > >> On 3/14/2019 10:04 PM, Thomas Monjalon wrote: > >>> 14/03/2019 03:58, Hyong Youb Kim: > On Wed, Mar 13, 2019 at 10:29:53PM +0100, Thomas Monjalon wrote: > > 13/03/2019 22

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-19 Thread Ferruh Yigit
On 3/19/2019 5:36 PM, Thomas Monjalon wrote: > 19/03/2019 18:29, Ferruh Yigit: >> On 3/14/2019 10:04 PM, Thomas Monjalon wrote: >>> 14/03/2019 03:58, Hyong Youb Kim: On Wed, Mar 13, 2019 at 10:29:53PM +0100, Thomas Monjalon wrote: > 13/03/2019 22:11, John Daley (johndale): >> From: Tho

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-19 Thread Thomas Monjalon
19/03/2019 18:29, Ferruh Yigit: > On 3/14/2019 10:04 PM, Thomas Monjalon wrote: > > 14/03/2019 03:58, Hyong Youb Kim: > >> On Wed, Mar 13, 2019 at 10:29:53PM +0100, Thomas Monjalon wrote: > >>> 13/03/2019 22:11, John Daley (johndale): > From: Thomas Monjalon > > 13/03/2019 19:32, Ferruh Y

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-19 Thread Ferruh Yigit
On 3/14/2019 10:04 PM, Thomas Monjalon wrote: > 14/03/2019 03:58, Hyong Youb Kim: >> On Wed, Mar 13, 2019 at 10:29:53PM +0100, Thomas Monjalon wrote: >>> 13/03/2019 22:11, John Daley (johndale): From: Thomas Monjalon > 13/03/2019 19:32, Ferruh Yigit: >> On 3/5/2019 7:11 AM, Hyong Youb

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-14 Thread Thomas Monjalon
14/03/2019 03:58, Hyong Youb Kim: > On Wed, Mar 13, 2019 at 10:29:53PM +0100, Thomas Monjalon wrote: > > 13/03/2019 22:11, John Daley (johndale): > > > From: Thomas Monjalon > > > > 13/03/2019 19:32, Ferruh Yigit: > > > > > On 3/5/2019 7:11 AM, Hyong Youb Kim wrote: > > > > > > The driver currentl

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-13 Thread Hyong Youb Kim
On Wed, Mar 13, 2019 at 10:29:53PM +0100, Thomas Monjalon wrote: > 13/03/2019 22:11, John Daley (johndale): > > From: Thomas Monjalon > > > 13/03/2019 19:32, Ferruh Yigit: > > > > On 3/5/2019 7:11 AM, Hyong Youb Kim wrote: > > > > > The driver currently has a devarg to set the rewrite mode during

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-13 Thread Thomas Monjalon
13/03/2019 22:11, John Daley (johndale): > From: Thomas Monjalon > > 13/03/2019 19:32, Ferruh Yigit: > > > On 3/5/2019 7:11 AM, Hyong Youb Kim wrote: > > > > The driver currently has a devarg to set the rewrite mode during > > > > init. Some apps want to programatically set it after running > > >

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-13 Thread John Daley (johndale)
Due to time zone differences, I'll answer for Hyong (below). -john > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, March 13, 2019 1:36 PM > To: Ferruh Yigit ; Hyong Youb Kim (hyonkim) > > Cc: Andrew Rybchenko ; Qi Zhang > ; dev@dpdk.org; John Daley (johndale) > ; Shahaf S

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-13 Thread Thomas Monjalon
13/03/2019 19:32, Ferruh Yigit: > On 3/5/2019 7:11 AM, Hyong Youb Kim wrote: > > The driver currently has a devarg to set the rewrite mode during > > init. Some apps want to programatically set it after running > > rte_eal_init() and finding that ports are VIC. Add a private function > > to support

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-13 Thread Ferruh Yigit
On 3/5/2019 7:11 AM, Hyong Youb Kim wrote: > The driver currently has a devarg to set the rewrite mode during > init. Some apps want to programatically set it after running > rte_eal_init() and finding that ports are VIC. Add a private function > to support such applications. It is not good idea t

[dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-04 Thread Hyong Youb Kim
The driver currently has a devarg to set the rewrite mode during init. Some apps want to programatically set it after running rte_eal_init() and finding that ports are VIC. Add a private function to support such applications. Signed-off-by: Hyong Youb Kim --- v2: * Move symbol to the experimental