Re: [dpdk-dev] [PATCH v2] ethdev: add sanity checks in control APIs

2021-04-29 Thread Stephen Hemminger
On Thu, 29 Apr 2021 10:48:34 -0700 Tyler Retzlaff wrote: > On Tue, Apr 13, 2021 at 11:22:14AM +0800, Min Hu (Connor) wrote: > > This patch adds more sanity checks in control path APIs. > > > > Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") > > Fixes: 3d98f921fbe9 ("ethdev: u

Re: [dpdk-dev] [PATCH v2] ethdev: add sanity checks in control APIs

2021-04-29 Thread Tyler Retzlaff
On Tue, Apr 13, 2021 at 11:22:14AM +0800, Min Hu (Connor) wrote: > This patch adds more sanity checks in control path APIs. > > Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") > Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and > variables") > Fixes: 03661377

Re: [dpdk-dev] [PATCH v2] ethdev: add sanity checks in control APIs

2021-04-14 Thread Min Hu (Connor)
Hi, Thanks Andrew, All has been fixed in v3, please review it, thanks. 在 2021/4/13 16:44, Andrew Rybchenko 写道: On 4/13/21 6:22 AM, Min Hu (Connor) wrote: This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes:

Re: [dpdk-dev] [PATCH v2] ethdev: add sanity checks in control APIs

2021-04-13 Thread Ferruh Yigit
On 4/13/2021 9:58 AM, Thomas Monjalon wrote: 13/04/2021 10:44, Andrew Rybchenko: On 4/13/21 6:22 AM, Min Hu (Connor) wrote: @@ -678,6 +684,9 @@ rte_eth_dev_owner_set(const uint16_t port_id, { int ret; + if (owner == NULL) + return -EINVAL; + Here and in many-many c

Re: [dpdk-dev] [PATCH v2] ethdev: add sanity checks in control APIs

2021-04-13 Thread Thomas Monjalon
13/04/2021 10:44, Andrew Rybchenko: > On 4/13/21 6:22 AM, Min Hu (Connor) wrote: > > @@ -678,6 +684,9 @@ rte_eth_dev_owner_set(const uint16_t port_id, > > { > > int ret; > > > > + if (owner == NULL) > > + return -EINVAL; > > + > > Here and in many-many cases below I think the or

Re: [dpdk-dev] [PATCH v2] ethdev: add sanity checks in control APIs

2021-04-13 Thread Andrew Rybchenko
On 4/13/21 6:22 AM, Min Hu (Connor) wrote: > This patch adds more sanity checks in control path APIs. > > Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") > Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and > variables") > Fixes: 0366137722a0 ("ethdev: check f

[dpdk-dev] [PATCH v2] ethdev: add sanity checks in control APIs

2021-04-12 Thread Min Hu (Connor)
This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for invalid device name") Fixes: d948f596fee2 ("ethdev: f