[dpdk-dev] [PATCH v2] eal: Clean up export of per_lcore__socket_id

2015-02-27 Thread David Marchand
Hello Neil, On Thu, Feb 26, 2015 at 1:48 PM, Neil Horman wrote: > diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c > b/lib/librte_eal/bsdapp/eal/eal_thread.c > index ca95c72..3672cdb 100644 > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c > @@ -59,

[dpdk-dev] [PATCH v2] eal: Clean up export of per_lcore__socket_id

2015-02-27 Thread Liang, Cunming
Hi, > -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Thursday, February 26, 2015 8:48 PM > To: dev at dpdk.org > Cc: thomas.monjalon at 6wind.com; Liang, Cunming; Neil Horman > Subject: [PATCH v2] eal: Clean up export of per_lcore__socket_id > > Theres no

[dpdk-dev] [PATCH v2] eal: Clean up export of per_lcore__socket_id

2015-02-26 Thread Neil Horman
Theres no need to export this variable. Its set and queried from an API call that doesn't exist in the hot path. Instead just export the rte_socket_id symbol and make the variable private to protect it from type changes. We should do this with the other exported variables too, but I think its to