Re: [dpdk-dev] [PATCH v2] eal/ppc64: improve rte_rdtsc with ppc_get_timebase

2020-03-11 Thread Thinh Tran
Hi David, Thanks for your response. We were worry about breaking the DPDK/FreeBSD on power, may hit the similar bug: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241146 From my understanding, and also from the documentation https://doc.dpdk.org/guides/freebsd_gsg/install_from_ports.html

Re: [dpdk-dev] [PATCH v2] eal/ppc64: improve rte_rdtsc with ppc_get_timebase

2020-03-10 Thread David Marchand
On Fri, Jan 31, 2020 at 11:04 PM Thinh Tran wrote: > > __ppc_get_timebase() is GNU extension and is more efficient > > v2: Advoid breaking other ppc_64 flatforms. The __ppc_get_timebase() > seems to be specific to powerpc platform and with GLIBC. dpdk only supports glibc at the moment.

Re: [dpdk-dev] [PATCH v2] eal/ppc64: improve rte_rdtsc with ppc_get_timebase

2020-02-10 Thread Thinh Tran
Hi, Sorry for late response. Yes this is the enhancement for powerpc. Observations on our power8/9 the __ppc_get_timebase calls __builtin_ppc_get_timebase () which is result in calling the mftb instruction __ppc_get_timebase(): mftb rA this instruction on a 64-bit implementation cop

Re: [dpdk-dev] [PATCH v2] eal/ppc64: improve rte_rdtsc with ppc_get_timebase

2020-02-05 Thread David Marchand
On Fri, Jan 31, 2020 at 11:04 PM Thinh Tran wrote: > > __ppc_get_timebase() is GNU extension and is more efficient The commit title and log are quite short and give little idea on what this is about. I had a look at this glibc helper: /* Read the Time Base Register. */ static __inline__ ui

Re: [dpdk-dev] [PATCH v2] eal/ppc64: improve rte_rdtsc with ppc_get_timebase

2020-02-04 Thread David Christensen
__ppc_get_timebase() is GNU extension and is more efficient v2: Advoid breaking other ppc_64 flatforms. The __ppc_get_timebase() seems to be specific to powerpc platform and with GLIBC. Signed-off-by: Thinh Tran Reviewed-by: David Christensen

[dpdk-dev] [PATCH v2] eal/ppc64: improve rte_rdtsc with ppc_get_timebase

2020-01-31 Thread Thinh Tran
__ppc_get_timebase() is GNU extension and is more efficient v2: Advoid breaking other ppc_64 flatforms. The __ppc_get_timebase() seems to be specific to powerpc platform and with GLIBC. Signed-off-by: Thinh Tran --- lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h | 7 +++