Re: [dpdk-dev] [PATCH v2] cycles: add isb before read cntvct_el0

2020-03-10 Thread Linhaifeng
> -Original Message- > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Tuesday, March 10, 2020 5:03 PM > To: Linhaifeng > Cc: Gavin Hu ; dev@dpdk.org; tho...@monjalon.net; > chenchanghu ; xudingke > ; Lilijun (Jerry) ; Honnappa > Nagarahalli ; Steve Capper > ; nd > Subject: Re:

Re: [dpdk-dev] [PATCH v2] cycles: add isb before read cntvct_el0

2020-03-10 Thread Jerin Jacob
On Tue, Mar 10, 2020 at 1:39 PM Linhaifeng wrote: Please change the subject to more meaningful one: Something like, eal/arm64: fix rdtsc precise version > We should use isb rather than dsb to sync system counter to cntvct_el0. Please tell "why" in commit message, something like this In order

Re: [dpdk-dev] [PATCH v2] cycles: add isb before read cntvct_el0

2020-03-10 Thread Gavin Hu
Reviewed-by: Gavin Hu

[dpdk-dev] [PATCH v2] cycles: add isb before read cntvct_el0

2020-03-10 Thread Linhaifeng
We should use isb rather than dsb to sync system counter to cntvct_el0. Reference of linux kernel: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/include/asm/arch_timer.h?h=v5.5#n220 Signed-off-by: Haifeng Lin --- .../common/include/arch/arm/rte_atomic_64.h