[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

2015-01-19 Thread Ravi Kerur
Looks like "make test" was added recently? I have "1.8.0" version and when I run "make test" after "make install T=x86_64-native-linuxapp-gcc" I get following errors root at user-PC:/home/rkerur/dpdk-new-5/dpdk# make test No test found, please do a 'make build' first, or specify O= root at user-PC

[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

2015-01-19 Thread David Marchand
On Mon, Jan 19, 2015 at 10:30 AM, Qiu, Michael wrote: > > This could be, but I hope every contributor could do basic check like > build and run of at lease one app like test-pmd, then it will reduce > most of failure we faced. > testpmd is fine, but make test should be preferred as it requires n

[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

2015-01-19 Thread Thomas Monjalon
2015-01-19 08:21, David Marchand: > On Mon, Jan 19, 2015 at 3:45 AM, Zhang, Helin > wrote: > > > It seems that your fix result in cannot launching applications. > > I don't suspect the correction of your fix, but somewhere else needs to be > > corrected together with your fix. > > > > Logs: > >

[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

2015-01-19 Thread Qiu, Michael
On 2015/1/19 17:50, David Marchand wrote: On Mon, Jan 19, 2015 at 10:30 AM, Qiu, Michael mailto:michael.qiu at intel.com>> wrote: This could be, but I hope every contributor could do basic check like build and run of at lease one app like test-pmd, then it will reduce most of failure we faced. te

[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

2015-01-19 Thread Qiu, Michael
On 2015/1/19 17:50, David Marchand wrote: On Mon, Jan 19, 2015 at 10:30 AM, Qiu, Michael mailto:michael.qiu at intel.com>> wrote: This could be, but I hope every contributor could do basic check like build and run of at lease one app like test-pmd, then it will reduce most of failure we faced. te

[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

2015-01-19 Thread Qiu, Michael
On 2015/1/19 17:14, Thomas Monjalon wrote: > 2015-01-19 08:21, David Marchand: >> On Mon, Jan 19, 2015 at 3:45 AM, Zhang, Helin >> wrote: >> >>> It seems that your fix result in cannot launching applications. >>> I don't suspect the correction of your fix, but somewhere else needs to be >>> corre

[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

2015-01-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of David Marchand > Sent: Monday, January 19, 2015 7:21 AM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] Fix rte_is_power_of_2 > > Hello, > > O

[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

2015-01-19 Thread Ravi Kerur
Sorry for the inconvenience. I was not aware of "make test" utility which does more elaborate testing. I will make a note of it and make sure future patches will go through it. I had done basic testing with testpmd as the changes were minimal. Thanks, Ravi On Mon, Jan 19, 2015 at 1:13 AM, Thomas

[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

2015-01-19 Thread David Marchand
Hello, On Mon, Jan 19, 2015 at 3:45 AM, Zhang, Helin wrote: > It seems that your fix result in cannot launching applications. > I don't suspect the correction of your fix, but somewhere else needs to be > corrected together with your fix. > > Logs: > /

[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

2015-01-19 Thread Zhang, Helin
+0xc9) [0x41c358]] 1: [./l3fwd(rte_dump_stack+0x18) [0x46e258]] Regards, Helin > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > Sent: Sunday, December 28, 2014 4:49 AM > To: Ravi Kerur > Cc: dev at dpdk.org > Subject: Re: [d

[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

2015-01-15 Thread Thomas Monjalon
> > rte_is_power_of_2 returns true for 0 and 0 is not power_of_2. Fix > > by checking for n. > > > > Signed-off-by: Ravi Kerur > Acked-by: Neil Horman Applied Thanks -- Thomas

[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

2014-12-27 Thread Neil Horman
On Sat, Dec 27, 2014 at 10:30:44AM -0500, Ravi Kerur wrote: > rte_is_power_of_2 returns true for 0 and 0 is not power_of_2. Fix > by checking for n. > > Signed-off-by: Ravi Kerur > --- > lib/librte_eal/common/include/rte_common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

2014-12-27 Thread Ravi Kerur
rte_is_power_of_2 returns true for 0 and 0 is not power_of_2. Fix by checking for n. Signed-off-by: Ravi Kerur --- lib/librte_eal/common/include/rte_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/in

[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

2014-12-27 Thread Ravi Kerur
Changes in v2 Make this a separate patch. rte_is_power_of_2 returns true for 0, fix by checking for n. Ravi Kerur (1): Fix rte_is_power_of_2 lib/librte_eal/common/include/rte_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.1