Re: [dpdk-dev] [PATCH v14 1/9] lib: build libraries that testpmd depends on

2021-06-29 Thread Jie Zhou
On Mon, Jun 28, 2021 at 07:10:01AM -0700, Tyler Retzlaff wrote: > On Mon, Jun 28, 2021 at 01:35:09PM +0300, Andrew Rybchenko wrote: > > On 6/28/21 1:01 PM, Andrew Rybchenko wrote: > > >On 6/24/21 1:34 AM, Jie Zhou wrote: > > >>Enable building libraries that testpmd depends on for Windows > > >> > >

Re: [dpdk-dev] [PATCH v14 1/9] lib: build libraries that testpmd depends on

2021-06-28 Thread Tyler Retzlaff
On Mon, Jun 28, 2021 at 01:35:09PM +0300, Andrew Rybchenko wrote: > On 6/28/21 1:01 PM, Andrew Rybchenko wrote: > >On 6/24/21 1:34 AM, Jie Zhou wrote: > >>Enable building libraries that testpmd depends on for Windows > >> > >>Signed-off-by: Jie Zhou > >>Signed-off-by: Jie Zhou > > > >Why are two

Re: [dpdk-dev] [PATCH v14 1/9] lib: build libraries that testpmd depends on

2021-06-28 Thread Andrew Rybchenko
On 6/28/21 1:01 PM, Andrew Rybchenko wrote: On 6/24/21 1:34 AM, Jie Zhou wrote: Enable building libraries that testpmd depends on for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Why are two a bit difference Signed-off-by used in these patches? Can we drop the first one and keep

Re: [dpdk-dev] [PATCH v14 1/9] lib: build libraries that testpmd depends on

2021-06-28 Thread Andrew Rybchenko
On 6/24/21 1:34 AM, Jie Zhou wrote: Enable building libraries that testpmd depends on for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Why are two a bit difference Signed-off-by used in these patches? Can we drop the first one and keep the second one which matches E-mail From?

Re: [dpdk-dev] [PATCH v14 1/9] lib: build libraries that testpmd depends on

2021-06-24 Thread Dmitry Kozlyuk
2021-06-23 15:34 (UTC-0700), Jie Zhou: > Enable building libraries that testpmd depends on for Windows > > Signed-off-by: Jie Zhou > Signed-off-by: Jie Zhou > --- > lib/meson.build | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/lib/meson.build b/lib/meson.build > index 4a64756

[dpdk-dev] [PATCH v14 1/9] lib: build libraries that testpmd depends on

2021-06-23 Thread Jie Zhou
Enable building libraries that testpmd depends on for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index 4a64756a68..1673ca4323 100644 --- a/lib/meson.build +++ b/lib/meso