Re: [dpdk-dev] [PATCH v14 1/6] lib: add information metrics library

2017-04-05 Thread Thomas Monjalon
2017-04-05 16:16, Remy Horton: > > On 05/04/2017 16:06, Thomas Monjalon wrote: > [..] > > Do you mean DEPDIRS-$(CONFIG_RTE_LIBRTE_METRICS) et al? > > I can remove them if you confirm. > > The ones in lib/librte_*/Makefile - yes those ones. I think they can be > removed as feb9f680cd2c ("mk: opti

Re: [dpdk-dev] [PATCH v14 1/6] lib: add information metrics library

2017-04-05 Thread Remy Horton
On 05/04/2017 16:06, Thomas Monjalon wrote: [..] Do you mean DEPDIRS-$(CONFIG_RTE_LIBRTE_METRICS) et al? I can remove them if you confirm. The ones in lib/librte_*/Makefile - yes those ones. I think they can be removed as feb9f680cd2c ("mk: optimize directory dependencies") changed the syste

Re: [dpdk-dev] [PATCH v14 1/6] lib: add information metrics library

2017-04-05 Thread Thomas Monjalon
2017-04-05 15:46, Remy Horton: > > On 05/04/2017 14:39, Thomas Monjalon wrote: > > 2017-03-30 22:00, Remy Horton: > >> --- a/mk/rte.app.mk > >> +++ b/mk/rte.app.mk > [..] > >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_METRICS)+= -lrte_metrics > > > > It should not be added here in --whole-archive as it

Re: [dpdk-dev] [PATCH v14 1/6] lib: add information metrics library

2017-04-05 Thread Remy Horton
On 05/04/2017 14:39, Thomas Monjalon wrote: 2017-03-30 22:00, Remy Horton: --- a/mk/rte.app.mk +++ b/mk/rte.app.mk [..] +_LDLIBS-$(CONFIG_RTE_LIBRTE_METRICS)+= -lrte_metrics It should not be added here in --whole-archive as it is not going to be used by plugins (drivers). I suggest

Re: [dpdk-dev] [PATCH v14 1/6] lib: add information metrics library

2017-04-05 Thread Thomas Monjalon
2017-03-30 22:00, Remy Horton: > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -98,6 +98,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_RING) += -lrte_ring > _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL)+= -lrte_eal > _LDLIBS-$(CONFIG_RTE_LIBRTE_CMDLINE)+= -lrte_cmdline > _LDLIBS-$(CONFIG_RT

[dpdk-dev] [PATCH v14 1/6] lib: add information metrics library

2017-03-30 Thread Remy Horton
This patch adds a new information metrics library. This Metrics library implements a mechanism by which producers can publish numeric information for later querying by consumers. Metrics themselves are statistics that are not generated by PMDs, and hence are not reported via ethdev extended statist