Re: [dpdk-dev] [PATCH v14 1/5] sched: add PIE based congestion management

2021-10-19 Thread Liguzinski, WojciechX
Hi Cristian, - As you asked I have added some points/one-liners in the patches what is changed - Regarding usage of rte_sched_cman_params structure I will write you a separate message - Reverted to use the RTE_SCHED_CMAN_RED flag - Also changed WRED occurrences back to RED - No, I wasn't getting

Re: [dpdk-dev] [PATCH v14 1/5] sched: add PIE based congestion management

2021-10-15 Thread Dumitrescu, Cristian
Hi Wojciech, Thank you for your patchset! Can you please, at least starting from this version, add a short change log at the top of your file, just after the signoff line? It helps a lot during the review process, and you can find abundant examples in other patchsets from this email list. One

[dpdk-dev] [PATCH v14 1/5] sched: add PIE based congestion management

2021-10-15 Thread Liguzinski, WojciechX
Implement PIE based congestion management based on rfc8033 Signed-off-by: Liguzinski, WojciechX --- drivers/net/softnic/rte_eth_softnic_tm.c | 6 +- lib/sched/meson.build| 10 +- lib/sched/rte_pie.c | 82 + lib/sched/rte_pie.h